Normalize compact stream flag - #2
Conversation
|
This pull request targeted The base branch has been automatically changed to |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This pull request targeted The base branch has been automatically changed to |
|
This pull request targeted The base branch has been automatically changed to |
There was a problem hiding this comment.
Code Review
This pull request modifies the OpenAI responses compact handler to normalize requests containing the "stream" parameter instead of rejecting them with a 400 Bad Request. Specifically, it removes the check that rejects "stream": true and instead deletes the "stream" field from the payload if it exists. The corresponding unit tests have been updated to verify this normalization behavior. I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
Closing this as diagnostic evidence only. The PR proved the Codex compact |
Summary
/v1/responses/compactrequests that includestream: truestreambefore dispatching the non-streaming compact executor pathstreamRoot Cause
The compact handler rejected
stream: truebefore provider execution, which produced the first compact stream parity blocker against the shim path. The shim-compatible behavior is to treat compact as a JSON compact response and ignore the stream flag.Validation
GitHub Actions unavailable due to exhausted Actions minutes; validation is local/manual only.
Local checks run:
go test ./sdk/api/handlers/openai -run 'TestOpenAIResponsesCompact'go build -o test-output ./cmd/serverthen removedtest-outputnode scripts/ci/protocol-parity-harness.js --plannode --test scripts/ci/protocol-parity-harness.test.jsgit diff --checkLive redacted parity note: the latest redacted report was inspected and identifies
compact_stream_true:cline-pass-glm-5-2as the first hard-gate blocker. A patched live redacted compare still needs to be run after deploying or launching this CLIProxyAPI build locally.