Skip to content

Update TypeSpec npm packages in dev container #7812

Closed

Description

@brooke-hamilton

Area for Improvement

The postCreateCommand in the dev container runs npm ci in the typespec folder. Some of the packages specified in the package-lock.json file are out of date.

Observed behavior

Building and running the dev container shows that some of the packages need to be updated.

Desired behavior

Packages should be current.

Proposed Fix

  1. Run npm update in the typespec folder and submit a PR for the changes.
  2. Find a way to add this folder to the dependabot checks.

rad Version

0.36

Operating system

No response

Additional context

No response

Would you like to support us?

  • Yes, I would like to support you

AB#12985

Activity

  1. added
    maintenanceIssue is a non-user-facing task like updating tests, improving automation, etc..
    on Aug 15, 2024
  2. radius-triage commented on Aug 15, 2024

    @radius-triage

    👋 @brooke-hamilton Thanks for filing this issue.

    A project maintainer will review this issue and get back to you soon.

    We also welcome community contributions! If you would like to pick this item up sooner and submit a pull request, please visit our contribution guidelines and assign this to yourself by commenting "/assign" on this issue.

    For more information on our triage process please visit our triage overview

  3. radius-triage commented on Aug 15, 2024

    @radius-triage

    👍 We've reviewed this issue and have agreed to add it to our backlog. Please subscribe to this issue for notifications, we'll provide updates when we pick it up.

    We also welcome community contributions! If you would like to pick this item up sooner and submit a pull request, please visit our contribution guidelines and assign this to yourself by commenting "/assign" on this issue.

    For more information on our triage process please visit our triage overview

  4. rynowak commented on Aug 16, 2024

    @rynowak
    Contributor

    @ytimocin @brooke-hamilton do we know why this isn't covered by depdendabot already?

  5. ytimocin commented on Aug 16, 2024

    @ytimocin
    Contributor

    @ytimocin @brooke-hamilton do we know why this isn't covered by depdendabot already?

    I will check this.

    Another update: when we run npm update and update package-lock.json, our tsp files need a lot of updates too. This work is probably bigger (in terms of scope) than just running the command.

  6. removed their assignment
    on Aug 28, 2024
  7. ytimocin commented on Aug 28, 2024

    @ytimocin
    Contributor

    Unassigned myself from this issue for now.

  8. self-assigned this
    on Oct 8, 2024
  9. ytimocin commented on Oct 16, 2024

    @ytimocin
    Contributor

    Completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

maintenanceIssue is a non-user-facing task like updating tests, improving automation, etc..triagedThis issue has been reviewed and triaged

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions