Skip to content

Update PR Contributor Checklist #8244

Closed

Description

@kachawla

Area for Improvement

PR contributor checklist: https://github.com/radius-project/radius/blob/main/.github/pull_request_template.md#contributor-checklist

Observed behavior

The current checklist doesn't provide a clear checkbox for scenarios where individual items are not applicable.

As an example, we have a checkbox for "An overview of proposed schema changes is included in a linked GitHub issue.".. but it doesn't guide the author on what to do if this is not applicable for the corresponding PR contribution - check the box/leave it empty/something else?

Desired behavior

Make it explicit for scenarios where the checklist item doesn't apply to the PR.

Proposed Fix

Add two checkbox options on each of the items - "Yes" and "Not Applicable". Based on the PR, one of the two options should be checked.

rad Version

N/A

Operating system

No response

Additional context

No response

Would you like to support us?

  • Yes, I would like to support you

AB#14080

Activity

  1. added
    maintenanceIssue is a non-user-facing task like updating tests, improving automation, etc..
    on Jan 15, 2025
  2. radius-triage commented on Jan 15, 2025

    @radius-triage

    👋 @kachawla Thanks for filing this issue.

    A project maintainer will review this issue and get back to you soon.

    We also welcome community contributions! If you would like to pick this item up sooner and submit a pull request, please visit our contribution guidelines and assign this to yourself by commenting "/assign" on this issue.

    For more information on our triage process please visit our triage overview

  3. added
    importantThis item is a high priority Issue we intend to address as soon as possible
    on Jan 15, 2025
  4. radius-triage commented on Jan 15, 2025

    @radius-triage

    We've prioritized work on this issue. Please subscribe to this issue for notifications, we'll provide updates as we make progress.

    We also welcome community contributions! If you would like to pick this item up sooner and submit a pull request, please visit our contribution guidelines and assign this to yourself by commenting "/assign" on this issue.

    For more information on our triage process please visit our triage overview

  5. self-assigned this
    on Jan 15, 2025
  6. removed
    importantThis item is a high priority Issue we intend to address as soon as possible
    on Jan 15, 2025
  7. kachawla commented on Jan 15, 2025

    @kachawla
    MemberAuthor

    I'm going to take care of it, this week or next.

  8. added a commit that references this issue on Jan 23, 2025
    7797bb0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

maintenanceIssue is a non-user-facing task like updating tests, improving automation, etc..

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions