rad init --preview should be able to work with radius.core environments. by nithyatsu · Pull Request #11639 · radius-project/radius

nithyatsu · 2026-04-14T00:32:20Z

Description

Adds rad init --preview (new init flow) and wires it into the CLI, while preserving existing rad init behavior.
Implements Radius.Core environment creation/selection in preview init
Updates rad env update --preview --recipe-packs to replace the environment recipe pack list (supports comma-separated values) and adds tests.
Refactors shared rad init prompt logic into pkg/cli/cmd/radinit/common and adds coverage for the extracted helpers.
updated rad deploy to create and inject default recipepack for any radius.core environment which dont have any recipepack.
fixed rad env update to take a comma seperated list of recipepacks , than using update to only add a pack incrementally.

Type of change

This pull request adds or changes features of Radius and has an approved issue (issue link required).

Fixes: #11490

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

An overview of proposed schema changes is included in a linked GitHub issue.
- Yes
- Not applicable
A design document PR is created in the design-notes repository, if new APIs are being introduced.
- Yes
- Not applicable
The design document has been reviewed and approved by Radius maintainers/approvers.
- Yes
- Not applicable
A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
- Yes
- Not applicable
A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
- Yes
- Not applicable
A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.
- Yes
- Not applicable

codecov · 2026-04-14T00:47:07Z

Codecov Report

❌ Patch coverage is 40.76577% with 789 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.06%. Comparing base (21ead27) to head (5ee7e48).

Files with missing lines	Patch %	Lines
pkg/cli/test_client_factory/radius_core.go	0.00%	189 Missing ⚠️
pkg/cli/cmd/radinit/common/display.go	0.00%	165 Missing ⚠️
pkg/cli/cmd/radinit/common/azure.go	0.00%	153 Missing ⚠️
pkg/cli/cmd/radinit/common/aws.go	0.00%	84 Missing ⚠️
pkg/cli/cmd/radinit/preview/environment.go	67.33%	30 Missing and 19 partials ⚠️
pkg/cli/cmd/radinit/preview/init.go	77.77%	29 Missing and 9 partials ⚠️
pkg/cli/cmd/radinit/common/cloud.go	42.42%	17 Missing and 2 partials ⚠️
pkg/cli/cmd/deploy/deploy.go	63.04%	11 Missing and 6 partials ⚠️
pkg/cli/recipepack/recipepack.go	64.44%	16 Missing ⚠️
pkg/cli/cmd/radinit/common/application.go	65.51%	5 Missing and 5 partials ⚠️
... and 11 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #11639      +/-   ##
==========================================
- Coverage   51.46%   51.06%   -0.40%     
==========================================
  Files         699      715      +16     
  Lines       44130    44940     +810     
==========================================
+ Hits        22710    22949     +239     
- Misses      19255    19817     +562     
- Partials     2165     2174       +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot

Pull request overview

This PR adds a --preview implementation path for rad init (and supporting plumbing) to target Radius.Core environments, including default recipe pack creation/injection and shared radinit prompting logic.

Changes:

Adds rad init --preview runner + shared radinit/common helpers for cluster/cloud/app prompts.
Introduces a pkg/cli/recipepack helper to create/ensure the default recipe pack and uses it from env create/deploy flows.
Updates env update recipe-pack semantics (replace list) and expands the test client factory to support new scenarios.

Reviewed changes

Copilot reviewed 34 out of 34 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
test/functional-portable/cli/noncloud/cli_test.go	Removes a dev-recipe functional test and related imports.
pkg/cli/test_client_factory/radius_core.go	Extends fake Core RP servers (env/recipe packs) for new test scenarios.
pkg/cli/recipepack/recipepack.go	Adds helpers for default recipe pack IDs/resources and ensure/create logic.
pkg/cli/recipepack/recipepack_test.go	Adds unit tests for default recipe pack generation.
pkg/cli/cmd/utils.go	Adds helper to populate recipe-pack clients by scope.
pkg/cli/cmd/utils_test.go	Adds tests for recipe-pack client population.
pkg/cli/cmd/radinit/preview/options.go	Adds interactive init options gathering for preview runner.
pkg/cli/cmd/radinit/preview/init.go	Adds `rad init --preview` command/runner wiring and execution flow.
pkg/cli/cmd/radinit/preview/init_test.go	Adds extensive validation/run tests for preview init.
pkg/cli/cmd/radinit/preview/environment.go	Implements preview environment creation using Radius.Core APIs + default recipe pack.
pkg/cli/cmd/radinit/preview/display.go	Adds preview TUI summary/progress display.
pkg/cli/cmd/radinit/preview/cluster.go	Delegates cluster option selection to common helpers.
pkg/cli/cmd/radinit/preview/cloud.go	Delegates cloud provider selection to common helpers.
pkg/cli/cmd/radinit/preview/azure.go	Implements Azure provider prompting for preview init.
pkg/cli/cmd/radinit/preview/aws.go	Implements AWS provider prompting for preview init.
pkg/cli/cmd/radinit/preview/application.go	Delegates application scaffolding prompts to common helpers.
pkg/cli/cmd/radinit/preview/application_test.go	Tests preview application prompt flow.
pkg/cli/cmd/radinit/common/cluster.go	New shared cluster selection/install-state helper code.
pkg/cli/cmd/radinit/common/cluster_test.go	Tests for shared cluster helpers.
pkg/cli/cmd/radinit/common/cloud.go	New shared cloud-provider prompt flow.
pkg/cli/cmd/radinit/common/cloud_test.go	Tests for shared cloud-provider flow.
pkg/cli/cmd/radinit/common/application.go	New shared application scaffold/name selection flow.
pkg/cli/cmd/radinit/common/application_test.go	Tests for shared application helpers.
pkg/cli/cmd/radinit/cluster.go	Refactors legacy init cluster selection to use shared helpers.
pkg/cli/cmd/radinit/cloud.go	Refactors legacy init cloud provider selection to use shared helpers.
pkg/cli/cmd/radinit/application.go	Refactors legacy init application prompts to use shared helpers.
pkg/cli/cmd/env/update/preview/update.go	Changes recipe-pack flag to “replace list” behavior and improves messaging.
pkg/cli/cmd/env/update/preview/update_test.go	Updates/extends tests to validate recipe-pack replacement + warning output.
pkg/cli/cmd/env/create/preview/create.go	Ensures default recipe pack exists and links it when creating an env.
pkg/cli/cmd/env/create/preview/create_test.go	Expands tests around default recipe pack creation and error paths.
pkg/cli/cmd/deploy/deploy.go	Injects default recipe pack into templates for Radius.Core environments when missing.
pkg/cli/cmd/deploy/deploy_test.go	Adds tests covering recipe-pack injection behavior during deploy.
pkg/cli/bicep/resources.go	Enhances template inspection to return Radius.Core environment resources.
cmd/rad/cmd/root.go	Wires `rad init` preview routing via `--preview`.

Copilot

Pull request overview

Copilot reviewed 34 out of 34 changed files in this pull request and generated 10 comments.

Signed-off-by: nithyatsu <nithyasu@microsoft.com>

Co-authored-by: Copilot <copilot@github.com>

radius-functional-tests · 2026-05-05T21:59:58Z

Radius functional test overview

🔍 Go to test action run

Click here to see the test run details

Name	Value
Repository	nithyatsu/radius
Commit ref	`5ee7e48`
Unique ID	func3a852858eb
Image tag	pr-func3a852858eb

gotestsum 1.13.0
KinD: v0.29.0
Dapr: 1.14.4
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func3a852858eb
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func3a852858eb
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func3a852858eb
controller test image location: ghcr.io/radius-project/dev/controller:pr-func3a852858eb
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func3a852858eb
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

…ts. (radius-project#11639) # Description - Adds `rad init --preview` (new init flow) and wires it into the CLI, while preserving existing `rad init` behavior. - Implements Radius.Core environment creation/selection in preview init - Updates `rad env update --preview --recipe-packs` to replace the environment recipe pack list (supports comma-separated values) and adds tests. - Refactors shared `rad init` prompt logic into `pkg/cli/cmd/radinit/common` and adds coverage for the extracted helpers. - updated rad deploy to create and inject default recipepack for any radius.core environment which dont have any recipepack. - fixed rad env update to take a comma seperated list of recipepacks , than using update to only add a pack incrementally. ## Type of change - This pull request adds or changes features of Radius and has an approved issue (issue link required). Fixes: [radius-project#11490 ](radius-project#11490) ## Contributor checklist Please verify that the PR meets the following requirements, where applicable: - An overview of proposed schema changes is included in a linked GitHub issue. - [ ] Yes  - [x] Not applicable  - A design document PR is created in the [design-notes repository](https://github.com/radius-project/design-notes/), if new APIs are being introduced. - [ ] Yes  - [x] Not applicable  - The design document has been reviewed and approved by Radius maintainers/approvers. - [x] Yes  - [ ] Not applicable  - A PR for the [samples repository](https://github.com/radius-project/samples) is created, if existing samples are affected by the changes in this PR. - [ ] Yes  - [x] Not applicable  - A PR for the [documentation repository](https://github.com/radius-project/docs) is created, if the changes in this PR affect the documentation or any user facing updates are made. - [ ] Yes  - [x] Not applicable  - A PR for the [recipes repository](https://github.com/radius-project/recipes) is created, if existing recipes are affected by the changes in this PR. - [ ] Yes  - [x] Not applicable  --------- Signed-off-by: nithyatsu <nithyasu@microsoft.com> Co-authored-by: Copilot <copilot@github.com> Signed-off-by: Reshma Abdul Rahim <reshmarahim.abdul@microsoft.com>

…13325) ## Summary Moves `pkg/cli/cmd/radinit/common` back into `pkg/cli/cmd/radinit` and deletes the layer that connected them. No user-visible behavior changes: every prompt, summary line and progress line is the same text. - **Package moved:** `common/{aws,azure,cloud,cluster,display}.go` replace the `radinit` shim files at the same paths, and `pkg/cli/cmd/radinit/common` is deleted. - **Shims removed:** - `Runner.enterAWSCloudProvider`, `enterAzureCloudProvider`, `enterCloudProviderOptions`, `enterClusterOptions`, `confirmOptions` and `showProgress` now contain the logic directly instead of wrapping a `common` function. The IRSA and workload-identity Helm values are set in the matching credential branch. - The constant aliases in `cloud.go` are gone. - **Duplicate types removed:** - `ClusterResult` was a copy of `clusterOptions`, and `CloudProviderResult` a copy of `cloudProviderOptions`. - `DisplayOptions`, `ClusterDisplay`, `EnvironmentDisplay` and `CloudProvidersDisplay` copied fields out of `initOptions`, and `toDisplayOptions` filled them in. The summary and progress views now read `initOptions` directly. - The `AzureProviderFunc`/`AWSProviderFunc` callback types are gone. They existed only because `common` couldn't import `radinit`. - **Unexported:** the 90 identifiers that `common` exported (prompt text constants, helper functions, the Bubble Tea models) are now package-private. Nothing outside `radinit` used them. The Bubble Tea model fields are lowercased too, and the tests carried over from `common` now use radinit's lowercase naming (for example `Test_selectCluster`). The renames were done with `gopls rename`. - **Tests:** - `common/cloud_test.go` is deleted: `Test_enterCloudProviderOptions` already covers each of its cases. - `common/cluster_test.go` is merged into `cluster_test.go`. Its two `EnterClusterOptions` cases now run through `Runner` as subtests of `Test_enterClusterOptions`. - `common/display_test.go` is merged into `display_test.go`. `Test_toDisplayOptions_ConfigFiles` is replaced by the existing view tests, which now build `initOptions{BicepConfigDirectory: ...}`. - A duplicate `getTestKubeConfig` helper is removed. - New: `Test_summaryModel_View_RecipePack` covers the recipe-pack line, which used to come from `toDisplayOptions`. `Test_enterAWSCloudProvider_*` now check the IRSA Helm value, which no test asserted before. ## Reason for change Part of radius-project#11803. `common` was split out in radius-project#11639 so the old `rad init` and `rad init --preview` could share prompt and display code. radius-project#13316 removed `rad init --preview`, so `radinit` is the only consumer left. That left about 230 lines of wrappers, constant aliases and translation types that existed only to cross a package boundary nobody needs. This PR restores the single-package shape `radinit` had before radius-project#11639. ## How to test 1. Run the unit tests: ```bash go test ./pkg/cli/cmd/radinit/... ./cmd/rad/... ``` 2. Confirm nothing still imports the old package: ```bash ! git grep -n '"github.com/radius-project/radius/pkg/cli/cmd/radinit/common"' -- '*.go' ``` 3. Review tip: the moved files replace shim files at the same paths, so GitHub shows them as rewrites rather than renames. To see what actually changed in each moved file, diff it against its `common` original: ```bash for f in aws azure cloud cluster display; do git diff -w origin/main:pkg/cli/cmd/radinit/common/$f.go HEAD:pkg/cli/cmd/radinit/$f.go done ``` Apart from the lowercased names and the `package` line, the only changes are the `Runner` receivers, the Helm `SetValues` lines, and `initOptions` replacing `DisplayOptions`. 4. Optional: run `rad init --full` against a kind cluster and check that the summary and progress screens look the same as before. Validation run locally: - `go build ./...`: passed - `go vet -tags e2e ./test/...`: passed - `go test ./cmd/rad/... ./pkg/cli/...`: passed - `golangci-lint run ./pkg/cli/cmd/radinit/...`: 0 issues, so the `unused` linter found no helper left dead by the fold. - Mutation check: removing the IRSA `SetValues` line, or the recipe-pack summary line, makes `Test_enterAWSCloudProvider_IRSA` or `Test_summaryModel_View_RecipePack` fail. ## File change summary | File | Summary of change | | ---- | ----------------- | | `pkg/cli/cmd/radinit/aws.go` | Replaced by `common/aws.go`. `enterAWSCloudProvider` is a `Runner` method that sets the IRSA Helm value; identifiers unexported | | `pkg/cli/cmd/radinit/azure.go` | Replaced by `common/azure.go`. `enterAzureCloudProvider` is a `Runner` method that sets the workload-identity Helm value; identifiers unexported | | `pkg/cli/cmd/radinit/cloud.go` | Replaced by `common/cloud.go`. `enterCloudProviderOptions` writes to `options.CloudProviders`; result and callback types removed | | `pkg/cli/cmd/radinit/cluster.go` | Replaced by `common/cluster.go`. `enterClusterOptions` writes to `options.Cluster`; `ClusterResult` removed | | `pkg/cli/cmd/radinit/display.go` | Replaced by `common/display.go`. Views read `initOptions`; `DisplayOptions` types and `toDisplayOptions` removed; `confirmOptions` and `showProgress` are `Runner` methods | | `pkg/cli/cmd/radinit/init.go` | Drop the `common` import and qualifiers | | `pkg/cli/cmd/radinit/aws_test.go` | Drop `common.` qualifiers; assert `SetValues` for access key (empty) and IRSA | | `pkg/cli/cmd/radinit/azure_test.go` | Drop `common.` qualifiers | | `pkg/cli/cmd/radinit/cloud_test.go` | Drop `common.` qualifiers | | `pkg/cli/cmd/radinit/cluster_test.go` | Merge `common/cluster_test.go`; installed and not-installed cases run through `Runner` | | `pkg/cli/cmd/radinit/display_test.go` | Merge `common/display_test.go`; views built from `initOptions`; add `Test_summaryModel_View_RecipePack` | | `pkg/cli/cmd/radinit/init_test.go` | Drop `common.` qualifiers | | `pkg/cli/cmd/radinit/common/*` | Deleted | --------- Signed-off-by: lakshmimsft <ljavadekar@microsoft.com>

nithyatsu had a problem deploying to external-contributor-approval April 14, 2026 00:32 — with GitHub Actions Failure

github-actions Bot mentioned this pull request Apr 14, 2026

Causinator 9000 CI Failure Digest — 2026-04-11 #11633

Closed

nithyatsu marked this pull request as ready for review April 23, 2026 15:44

nithyatsu requested a review from a team as a code owner April 23, 2026 15:44

Copilot AI review requested due to automatic review settings April 23, 2026 15:44

nithyatsu requested a review from a team as a code owner April 23, 2026 15:44

nithyatsu marked this pull request as draft April 23, 2026 15:44

Copilot started reviewing on behalf of nithyatsu April 23, 2026 15:45

View session

Copilot AI reviewed Apr 23, 2026

View reviewed changes

nithyatsu force-pushed the working branch from d0dc480 to be6c128 Compare April 23, 2026 17:24

nithyatsu added the pr:important High-impact changes needing special attention during release and in release notes label Apr 23, 2026

nithyatsu marked this pull request as ready for review April 23, 2026 19:17

nithyatsu force-pushed the working branch from e4f7301 to 0719c8c Compare April 23, 2026 19:18

nithyatsu changed the title ~~rad init new + old env support with a --preview flag~~ rad init --preview should be able to work with new environments and recipe pack. Apr 23, 2026

nithyatsu changed the title ~~rad init --preview should be able to work with new environments and recipe pack.~~ rad init --preview should be able to work with radius.core environments. Apr 23, 2026

brooke-hamilton requested a review from Copilot April 27, 2026 13:31

Copilot started reviewing on behalf of brooke-hamilton April 27, 2026 13:32

View session

Copilot AI reviewed Apr 27, 2026

View reviewed changes

This was referenced Apr 30, 2026

[c9k:2df99ce2] CI regression in commit 2df99ce2 (14 failed jobs) #11781

Closed

[c9k:9a5fd7fc] CI regression in commit 9a5fd7fc (15 failed jobs) #11782

Closed

nithyatsu force-pushed the working branch from 9a5fd7f to 664ae88 Compare April 30, 2026 20:16

willtsai reviewed Apr 30, 2026

View reviewed changes

Comment thread pkg/cli/cmd/radinit/preview/init.go Resolved

willtsai reviewed Apr 30, 2026

View reviewed changes

Comment thread pkg/cli/cmd/env/update/preview/update.go Resolved

kachawla reviewed May 4, 2026

View reviewed changes

Comment thread pkg/cli/cmd/radinit/preview/aws.go Resolved

nithyatsu force-pushed the working branch from 42a5ce0 to 7aa87ab Compare May 4, 2026 20:38

nithyatsu requested review from kachawla and willtsai May 4, 2026 21:48

nithyatsu requested a review from a team as a code owner May 4, 2026 21:49

kachawla approved these changes May 5, 2026

View reviewed changes

nithyatsu and others added 21 commits May 5, 2026 08:52

remove dev recipe related code.

d2a5b74

Signed-off-by: nithyatsu <nithyasu@microsoft.com>

remove obsolete tests

af87370

Signed-off-by: nithyatsu <nithyasu@microsoft.com>

refactoring

cb81c27

Signed-off-by: nithyatsu <nithyasu@microsoft.com>

fix errors

74d3c7a

Signed-off-by: nithyatsu <nithyasu@microsoft.com>

rad init support new and old env

7e6538e

Signed-off-by: nithyatsu <nithyasu@microsoft.com>

refactor applications.go

e4e5c49

Signed-off-by: nithyatsu <nithyasu@microsoft.com>

refactor common code

d347786

Signed-off-by: nithyatsu <nithyasu@microsoft.com>

wip

5aec669

Signed-off-by: nithyatsu <nithyasu@microsoft.com>

wip

6459702

Signed-off-by: nithyatsu <nithyasu@microsoft.com>

wip

0a3aa69

Signed-off-by: nithyatsu <nithyasu@microsoft.com>

pop up rad core env list

893ff4b

Co-authored-by: Copilot <copilot@github.com>

wip

07a4cf1

Co-authored-by: Copilot <copilot@github.com>

wip

abcee35

wip

d142b77

wip

cd710e6

wip confirm to mockgen version on CI

5524a3b

fix text

392506f

Co-authored-by: Copilot <copilot@github.com>

refactor

4707b77

Co-authored-by: Copilot <copilot@github.com>

refactor

79ca800

Co-authored-by: Copilot <copilot@github.com>

wip

760d31f

Co-authored-by: Copilot <copilot@github.com>

refactor

5bc5b4b

nithyatsu force-pushed the working branch from aa6a61a to 5bc5b4b Compare May 5, 2026 15:52

willtsai linked an issue May 5, 2026 that may be closed by this pull request

Default Recipe Packs for K8s #11074

Closed

Merge branch 'main' into working

5ee7e48

nithyatsu merged commit 1d1b316 into radius-project:main May 5, 2026
57 checks passed

willtsai mentioned this pull request May 7, 2026

Publish default Kubernetes recipes pack .bicep to contrib repo and consume in Radius #11835

Open

lakshmimsft mentioned this pull request Oct 17, 2026

refactor(cli): fold radinit/common back into radinit #13325

Merged

Conversation

nithyatsu commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

Contributor checklist

Uh oh!

codecov Bot commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

radius-functional-tests Bot commented May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Radius functional test overview

Test Status

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

nithyatsu commented Apr 14, 2026 •

edited

Loading

codecov Bot commented Apr 14, 2026 •

edited

Loading

radius-functional-tests Bot commented May 5, 2026 •

edited

Loading