[Copilot]

Description

POST .../providers/Radius.Core/applications/{app}/getGraph returned 404 because the namespace builder for Radius.Core never wired the getGraph custom action — only Applications.Core/applications did. The OpenAPI route exists but had no controller, blocking app graph rendering in the dashboard.

• New controller: GetGraphv20250801preview in pkg/corerp/frontend/controller/applications/v20250801preview/getgraph.go (package v20250801preview). Placed in a v20250801preview/ subpackage to match the convention established by pkg/corerp/frontend/controller/environments/v20250801preview/. Typed against datamodel.Application_v20250801preview and uses the Application20250801* converters.

• Shared helper: Extracted a ComputeGraphResponse exported helper in the parent pkg/corerp/frontend/controller/applications package so both the Applications.Core and Radius.Core getGraph controllers reuse the same graph-listing logic (resource type discovery, application-/environment-scoped listing, and graph computation) without duplication.

• Stricter validation: ComputeGraphResponse uses resources.ParseResource (instead of resources.Parse) to validate the environment ID is a named resource, rejecting collection or custom-action IDs. The error is wrapped with fmt.Errorf for context.

• Wiring: SetupRadiusCoreNamespace in pkg/corerp/setup/setup.go now registers Custom["getGraph"] on the applications resource, analogous to the Applications.Core/applications registration.

• Tests: Unit test for the not-found path on the new controller, plus a router assertion in setup_test.go that POST .../radius.core/applications/app0/getgraph resolves to ACTIONGETGRAPH. Additional tests targeting the lines flagged by Codecov:

  • ComputeGraphResponse invalid-environment-ID error path.
  • ComputeGraphResponse UCP error-propagation path, driven by an httptest UCP server returning 500 on /planes/radius/local/providers.
  • ComputeGraphResponse listAllResourcesByApplication error path (lines 62-63), driven by an httptest server returning a resource type then failing on GetProviderSummary.
  • ComputeGraphResponse listAllResourcesByEnvironment error path (lines 67-68), driven by an httptest server where application-scoped listing succeeds but environment-scoped listing returns 500.
  • Database error path through GetGraph.Run and GetGraphv20250801preview.Run (non-NotFound Get error is propagated).
  • End-to-end success path through both Run methods into ComputeGraphResponse, driven by an httptest UCP server returning an empty providers list to yield an empty graph.

  Coverage on the new shared helper rose from 0% to ~87.5%, both Run methods are at 100%, and the v20250801preview getGraph package is at 100%.

Custom: map[string]builder.Operation[datamodel.Application_v20250801preview]{
    "getGraph": {
        APIController: func(opt apictrl.Options) (apictrl.Controller, error) {
            return app_v20250801_ctrl.NewGetGraphv20250801preview(opt, *recipeControllerConfig.UCPConnection)
        },
    },
},

Type of change

• This pull request fixes a bug in Radius and has an approved issue (issue link required).

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

• An overview of proposed schema changes is included in a linked GitHub issue.
  • Yes
  • Not applicable
• A design document is added or updated under eng/design-notes/ in this repository, if new APIs are being introduced.
  • Yes
  • Not applicable
• The design document has been reviewed and approved by Radius maintainers/approvers.
  • Yes
  • Not applicable
• A PR for resource-types-contrib is created, if resource types or recipes are affected by the changes in this PR.
  • Yes
  • Not applicable
• A PR for dashboard is created, if the Radius Dashboard is affected by the changes in this PR.
  • Yes
  • Not applicable
• A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
  • Yes
  • Not applicable

[willtsai]

@copilot - should the new controller follow the file path conventions established in pkg/corerp/frontend/controller/environments instead?

[Copilot]

@copilot - should the new controller follow the file path conventions established in pkg/corerp/frontend/controller/environments instead?

Good catch — moved the new controller into pkg/corerp/frontend/controller/applications/v20250801preview/getgraph.go (package v20250801preview), matching the environments/v20250801preview/ layout. Extracted a shared ComputeGraphResponse helper in the parent applications package so both controllers reuse the same graph logic. Done in 7dc9649.

[github-actions]

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

[github-actions]

Unit Tests

    2 files  ± 0    421 suites  +1   7m 18s ⏱️ +39s
5 034 tests +11  5 032 ✅ +11  2 💤 ±0  0 ❌ ±0 
6 061 runs  +11  6 059 ✅ +11  2 💤 ±0  0 ❌ ±0 

Results for commit e383e73. ± Comparison against base commit 8ad0d19.

♻️ This comment has been updated with latest results.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.40%. Comparing base (8ad0d19) to head (e383e73).

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #11796      +/-   ##
==========================================
+ Coverage   51.19%   51.40%   +0.20%     
==========================================
  Files         715      716       +1     
  Lines       45081    45106      +25     
==========================================
+ Hits        23079    23186     +107     
+ Misses      19803    19721      -82     
  Partials     2199     2199              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[willtsai]

@copilot - please take a look at the codecov report here and add the necessary tests to improve coverage.

[Copilot]

@copilot - please take a look at the codecov report here and add the necessary tests to improve coverage.

Added a test for the ComputeGraphResponse helper covering the invalid-environment-ID parse-error path in cf948d6, which lifts coverage on the new shared helper from 0%. The remaining branches (UCP ListAllResourceTypesNames / listAllResourcesByApplication / listAllResourcesByEnvironment) make live HTTP calls through an inline-constructed UCPApplicationsManagementClient, so covering them would require introducing a UCP HTTP test server (or DI'ing the client) — happy to do that in a follow-up if you'd like, but it's a meaningfully larger refactor than the original bug fix.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• app.codecov.io
  • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

[willtsai]

@copilot - are you able to view the codecov report via this link to review and improve the test coverage as called out by the report?
https://app.codecov.io/gh/radius-project/radius/pull/11796?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=radius-project

[willtsai]

This is now ready for review. I've built and validated that this works, see below.

Radius v0.56.1

$ curl -X POST \
  '[http://localhost:8001/apis/api.ucp.dev/v1alpha3/planes/radius/local/resourcegroups/default/provider…](http://localhost:8001/apis/api.ucp.dev/v1alpha3/planes/radius/local/resourcegroups/default/providers/Radius.Core/applications/aca-testapp-dapr/getGraph?api-version=2025-08-01-preview%27) \
  -H 'Content-Type: application/json' \
  -d '{}'
{
  "error": {
    "code": "NotFound",
    "message": "The request 'POST /planes/radius/local/resourcegroups/default/providers/radius.core/applications/aca-testapp-dapr/getgraph' is invalid."
  }
}

Radius build of this branch

$ curl -X POST \
  '[http://localhost:8001/apis/api.ucp.dev/v1alpha3/planes/radius/local/resourcegroups/default/provider…](http://localhost:8001/apis/api.ucp.dev/v1alpha3/planes/radius/local/resourcegroups/default/providers/Radius.Core/applications/aca-testapp-dapr/getGraph?api-version=2025-08-01-preview%27) \
  -H 'Content-Type: application/json' \
  -d '{}'
{
  "resources": [
    {
      "connections": [
        {
          "direction": "Inbound",
          "id": "/planes/radius/local/resourcegroups/default/providers/Radius.Compute/containers/backend"
        }
      ],
      "id": "/planes/radius/local/resourcegroups/default/providers/Applications.Dapr/stateStores/statestore",
      "name": "statestore",
      "outputResources": [
        {
          "id": "/subscriptions/85716382-7362-45c3-ae03-2126e459a123/resourceGroups/willtsai-prod-aca/providers/Microsoft.App/managedEnvironments/aca-wp-egress-env/daprComponents/statestore",
          "name": "statestore",
          "type": "Microsoft.App/managedEnvironments/daprComponents"
        },
        {
          "id": "/subscriptions/85716382-7362-45c3-ae03-2126e459a123/resourceGroups/willtsai-prod-aca/providers/Microsoft.App/managedEnvironments/aca-wp-egress-env/daprComponents/statestore",
          "name": "statestore",
          "type": "Microsoft.App/managedEnvironments/daprComponents"
        },
        {
          "id": "/subscriptions/85716382-7362-45c3-ae03-2126e459a123/resourceGroups/willtsai-prod-aca/providers/Microsoft.Cache/redis/recipevolsfgywvnst6",
          "name": "recipevolsfgywvnst6",
          "type": "Microsoft.Cache/redis"
        },
        {
          "id": "/subscriptions/85716382-7362-45c3-ae03-2126e459a123/resourceGroups/willtsai-prod-aca/providers/Microsoft.Cache/redis/recipevolsfgywvnst6",
          "name": "recipevolsfgywvnst6",
          "type": "Microsoft.Cache/redis"
        }
      ],
      "provisioningState": "Succeeded",
      "type": "Applications.Dapr/stateStores"
    },
    {
      "connections": [
        {
          "direction": "Outbound",
          "id": "/planes/radius/local/resourcegroups/default/providers/Applications.Dapr/stateStores/statestore"
        }
      ],
      "id": "/planes/radius/local/resourcegroups/default/providers/Radius.Compute/containers/backend",
      "name": "backend",
      "outputResources": [
        {
          "id": "/subscriptions/85716382-7362-45c3-ae03-2126e459a123/resourceGroups/willtsai-prod-aca/providers/Microsoft.App/containerApps/backend-qjpn7qj7",
          "name": "backend-qjpn7qj7",
          "type": "Microsoft.App/containerApps"
        },
        {
          "id": "/subscriptions/85716382-7362-45c3-ae03-2126e459a123/resourceGroups/willtsai-prod-aca/providers/Microsoft.App/containerApps/backend-qjpn7qj7",
          "name": "backend-qjpn7qj7",
          "type": "Microsoft.App/containerApps"
        }
      ],
      "provisioningState": "Succeeded",
      "type": "Radius.Compute/containers"
    },
    {
      "connections": [],
      "id": "/planes/radius/local/resourcegroups/default/providers/Radius.Compute/containers/frontend",
      "name": "frontend",
      "outputResources": [
        {
          "id": "/subscriptions/85716382-7362-45c3-ae03-2126e459a123/resourceGroups/willtsai-prod-aca/providers/Microsoft.App/containerApps/frontend-62uirid4",
          "name": "frontend-62uirid4",
          "type": "Microsoft.App/containerApps"
        },
        {
          "id": "/subscriptions/85716382-7362-45c3-ae03-2126e459a123/resourceGroups/willtsai-prod-aca/providers/Microsoft.App/containerApps/frontend-62uirid4",
          "name": "frontend-62uirid4",
          "type": "Microsoft.App/containerApps"
        }
      ],
      "provisioningState": "Succeeded",
      "type": "Radius.Compute/containers"
    }
  ]
}

[Copilot]

Pull request overview

This PR fixes the Radius.Core/applications/{app}/getGraph custom action returning 404 by wiring the custom action into the Radius.Core namespace builder, adding a v20250801preview controller for the action, and extracting shared graph-computation logic so both Applications.Core and Radius.Core controllers reuse it.

Changes:

• Register getGraph as a custom action on Radius.Core/applications in SetupRadiusCoreNamespace.
• Add a v20250801preview getGraph controller for Radius.Core/applications and route it to shared graph computation.
• Extract ComputeGraphResponse helper and expand unit/router tests for both namespaces and error/success paths.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
pkg/corerp/setup/setup.go	Registers getGraph custom action for Radius.Core/applications and wires it to the new controller.
pkg/corerp/setup/setup_test.go	Adds router assertion coverage for POST .../radius.core/applications/{app}/getgraph resolving to ACTIONGETGRAPH.
pkg/corerp/frontend/controller/applications/v20250801preview/getgraph.go	Introduces Radius.Core v20250801preview getGraph controller delegating to shared graph logic.
pkg/corerp/frontend/controller/applications/v20250801preview/getgraph_test.go	Adds unit tests for not-found, DB error propagation, and success path for the new controller.
pkg/corerp/frontend/controller/applications/getgraph.go	Extracts ComputeGraphResponse helper used by both getGraph controllers.
pkg/corerp/frontend/controller/applications/getgraph_test.go	Adds targeted unit tests to cover ComputeGraphResponse error paths and controller DB/success paths.

[willtsai]

Confirmed on the dasboard as well where Radius.Core/applications graph is being rendered:

[radius-functional-tests]

Radius functional test overview

🔍 Go to test action run

Click here to see the test run details

Name	Value
Repository	radius-project/radius
Commit ref	e383e73
Unique ID	func69db2c6f41
Image tag	pr-func69db2c6f41

• gotestsum 1.13.0
• KinD: v0.29.0
• Dapr: 1.14.4
• Azure KeyVault CSI driver: 1.4.2
• Azure Workload identity webhook: 1.3.0
• Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func69db2c6f41
• Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
• applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func69db2c6f41
• dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func69db2c6f41
• controller test image location: ghcr.io/radius-project/dev/controller:pr-func69db2c6f41
• ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func69db2c6f41
• deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ ucp-cloud functional tests succeeded
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded