Fix run-rad-commands parse regression and add shell syntax gate for extension actions

[Copilot]

Summary

run-rad-commands on @main was bricked by an unclosed cleanup() function in the composite action shell block, causing immediate bash parse failure before any rad command could run. This PR restores the missing brace and adds a CI guard that syntax-checks all extension action run: | blocks.

• Action runtime fix
  • Close cleanup() before trap cleanup EXIT in run-rad-commands/action.yml so the script parses and executes.
• Regression prevention
  • Add a shell test that extracts every .github/extension/actions/**/action.yml run: | block and validates each with bash -n.
• CI wiring
  • Add test-extension-action-shell-syntax target and include it in the top-level test target.

cleanup() {
  # ...
  write_result
}
trap cleanup EXIT

Reason for change

A single missing } in the composite action shell block made the deploy path non-functional for workflows pinned to @main. YAML/action linting did not catch this class of failure; explicit shell parsing is required.

How to test

Run the focused shell regression checks:

make test-run-rad-commands-action
make test-extension-action-shell-syntax

File change summary

File	Summary of change
.github/extension/actions/run-rad-commands/action.yml	Restored the missing closing brace for cleanup() before trap cleanup EXIT in the Run rad commands shell block.
.github/extension/actions/action-shell-syntax_test.sh	Added a new regression test that parses all extension action `run:
build/test.mk	Added test-extension-action-shell-syntax target and wired it into the aggregate test target so CI enforces the syntax gate.

• Fixes run-rad-commands action on main is unparseable: cleanup() missing closing brace breaks all deploys #12773

[github-actions]

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

[sk593]

@copilot resolve conflicts

[Copilot]

Pull request overview

Fixes a bash parse regression in the run-rad-commands extension composite action and adds a CI-enforced guard to prevent future unparseable run: | scripts in extension actions.

Changes:

• Restored the missing } that closes cleanup() in .github/extension/actions/run-rad-commands/action.yml so the action’s bash script parses and runs.
• Added .github/extension/actions/action-shell-syntax_test.sh to extract each extension action run: | block and validate it with bash -n.
• Wired the new syntax gate into make test via build/test.mk so it runs in CI.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
.github/extension/actions/run-rad-commands/action.yml	Fixes the unclosed cleanup() function to eliminate the immediate bash parse failure.
.github/extension/actions/action-shell-syntax_test.sh	Adds a regression test that syntax-checks extracted composite-action `run:
build/test.mk	Adds test-extension-action-shell-syntax and includes it in the aggregate test target.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

@copilot resolve conflicts

Resolved in merge commit 1f29012. It retains both the shell-syntax test target and main's validation test package.

[radius-functional-tests]

Radius functional test overview

🔍 Go to test action run

Click here to see the test run details

Name	Value
Repository	radius-project/radius
Commit ref	1f29012
Unique ID	funcab68ed89ba
Image tag	pr-funcab68ed89ba

• Dapr: 1.14.4
• Azure KeyVault CSI driver: 1.4.2
• Azure Workload identity webhook: 1.3.0
• Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcab68ed89ba
• Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
• applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcab68ed89ba
• dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funcab68ed89ba
• controller test image location: ghcr.io/radius-project/dev/controller:pr-funcab68ed89ba
• ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcab68ed89ba
• deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

[github-actions]

Unit Tests

    2 files  ±0    459 suites  ±0   7m 39s ⏱️ + 1m 13s
6 355 tests ±0  6 353 ✅ ±0  2 💤 ±0  0 ❌ ±0 
7 613 runs  ±0  7 611 ✅ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 1f29012. ± Comparison against base commit 787b6ca.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.95%. Comparing base (787b6ca) to head (1f29012).

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #12775   +/-   ##
=======================================
  Coverage   53.94%   53.95%           
=======================================
  Files         774      774           
  Lines       51991    51991           
=======================================
+ Hits        28049    28054    +5     
+ Misses      21315    21311    -4     
+ Partials     2627     2626    -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.