Pin dependencies for typespec compilation by rynowak · Pull Request #8019 · radius-project/radius

rynowak · 2024-10-31T18:02:08Z

Description

This change pins the dependencies we use for the TypeSpec compiler. Since these were set to latest, it's easy to operate on a configuration we don't support. TypeSpec moves fast and breaks things, so being certain about the dependencies is important.

Also adds the package.json to depdendabot so we can get PRs for updates.

Type of change

This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

An overview of proposed schema changes is included in a linked GitHub issue.
A design document PR is created in the design-notes repository, if new APIs are being introduced.
If applicable, design document has been reviewed and approved by Radius maintainers/approvers.
A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.

rynowak · 2024-10-31T18:06:02Z

+    "@typespec/http": "^0.60.0",
+    "@typespec/openapi": "^0.60.0",
+    "@typespec/rest": "^0.60.0",
+    "@typespec/versioning": "^0.60.0"


PTAL at the package-lock.json to verify. We're still installing the same versions, but the version ranges we consider allowed are constrained.

radius-functional-tests · 2024-10-31T18:09:32Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	rynowak/radius
Commit ref	`5d05c54`
Unique ID	funce81846b530
Image tag	pr-funce81846b530

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funce81846b530
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funce81846b530
controller test image location: ghcr.io/radius-project/dev/controller:pr-funce81846b530
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funce81846b530
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

brooke-hamilton

LGTM: Running make generate in the dev container results in zero changes to the generated code. 🚀

codecov · 2024-10-31T18:45:14Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.30%. Comparing base (2bc71ab) to head (0a86352).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8019      +/-   ##
==========================================
- Coverage   59.31%   59.30%   -0.02%     
==========================================
  Files         560      560              
  Lines       37495    37495              
==========================================
- Hits        22242    22236       -6     
- Misses      13706    13710       +4     
- Partials     1547     1549       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

radius-functional-tests · 2024-10-31T20:23:29Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	rynowak/radius
Commit ref	`700b4d4`
Unique ID	func12e73a8658
Image tag	pr-func12e73a8658

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func12e73a8658
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func12e73a8658
controller test image location: ghcr.io/radius-project/dev/controller:pr-func12e73a8658
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func12e73a8658
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

lakshmimsft

I tried to dismiss my own review/approval but looks like I cannot in Github. We're updating to ~0.60.0 as mentioned above

superbeeny

LGTM

This change pins the dependencies we use for the TypeSpec compiler. Since these were set to latest, it's easy to operate on a configuration we don't support. TypeSpec moves fast and breaks things, so being certain about the dependencies is important. Also adds the package.json to depdendabot so we can get PRs for updates. Signed-off-by: Ryan Nowak <nowakra@gmail.com>

rynowak · 2024-11-04T17:11:06Z

@brooke-hamilton - ready for a rereview!

radius-functional-tests · 2024-11-04T17:37:40Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	rynowak/radius
Commit ref	`0a86352`
Unique ID	func914c1f05ad
Image tag	pr-func914c1f05ad

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func914c1f05ad
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func914c1f05ad
controller test image location: ghcr.io/radius-project/dev/controller:pr-func914c1f05ad
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func914c1f05ad
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

brooke-hamilton

@rynowak looks good: rebuild dev container --> make generate --> zero file changes.

rynowak · 2024-11-04T18:01:13Z

Will need yet another approval after updating to latest main 😆

Stale

radius-functional-tests · 2024-11-04T18:01:54Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	rynowak/radius
Commit ref	`94a486a`
Unique ID	funccafd769c57
Image tag	pr-funccafd769c57

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funccafd769c57
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funccafd769c57
controller test image location: ghcr.io/radius-project/dev/controller:pr-funccafd769c57
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funccafd769c57
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

rynowak requested review from a team as code owners October 31, 2024 18:02

rynowak commented Oct 31, 2024

View reviewed changes

rynowak temporarily deployed to functional-tests October 31, 2024 18:08 — with GitHub Actions Inactive

sk593 previously approved these changes Oct 31, 2024

View reviewed changes

brooke-hamilton reviewed Oct 31, 2024

View reviewed changes

Comment thread .github/dependabot.yml Resolved

lakshmimsft approved these changes Oct 31, 2024

View reviewed changes

brooke-hamilton reviewed Oct 31, 2024

View reviewed changes

Comment thread typespec/package.json Resolved

rynowak temporarily deployed to functional-tests October 31, 2024 20:22 — with GitHub Actions Inactive

ytimocin previously approved these changes Oct 31, 2024

View reviewed changes

lakshmimsft approved these changes Oct 31, 2024

View reviewed changes

lakshmimsft previously requested changes Oct 31, 2024

View reviewed changes

superbeeny approved these changes Nov 1, 2024

View reviewed changes

rynowak dismissed stale reviews from ytimocin and sk593 via 4d710b2 November 4, 2024 17:09

rynowak force-pushed the rynowak/pin-typespec branch from 700b4d4 to 4d710b2 Compare November 4, 2024 17:09

rynowak force-pushed the rynowak/pin-typespec branch from 4d710b2 to 0a86352 Compare November 4, 2024 17:10

rynowak temporarily deployed to functional-tests November 4, 2024 17:36 — with GitHub Actions Inactive

brooke-hamilton approved these changes Nov 4, 2024

View reviewed changes

Merge branch 'main' into rynowak/pin-typespec

94a486a

rynowak temporarily deployed to functional-tests November 4, 2024 18:00 — with GitHub Actions Inactive

ytimocin approved these changes Nov 4, 2024

View reviewed changes

rynowak merged commit 3492b53 into radius-project:main Nov 4, 2024

rynowak deleted the rynowak/pin-typespec branch November 4, 2024 18:31

brooke-hamilton mentioned this pull request Mar 19, 2025

REQUEST: Approvership for brooke-hamilton radius-project/community#80

Closed

4 tasks done

Conversation

rynowak commented Oct 31, 2024

Description

Type of change

Contributor checklist

Uh oh!

rynowak Oct 31, 2024

Choose a reason for hiding this comment

Uh oh!

radius-functional-tests Bot commented Oct 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Radius functional test overview

Test Status

Uh oh!

brooke-hamilton left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Oct 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

radius-functional-tests Bot commented Oct 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Radius functional test overview

Test Status

Uh oh!

lakshmimsft left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

superbeeny left a comment

Choose a reason for hiding this comment

Uh oh!

rynowak commented Nov 4, 2024

Uh oh!

radius-functional-tests Bot commented Nov 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Radius functional test overview

Test Status

Uh oh!

brooke-hamilton left a comment

Choose a reason for hiding this comment

Uh oh!

rynowak commented Nov 4, 2024

Uh oh!

radius-functional-tests Bot commented Nov 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Radius functional test overview

Test Status

Uh oh!

This branch was previously deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

radius-functional-tests Bot commented Oct 31, 2024 •

edited

Loading

codecov Bot commented Oct 31, 2024 •

edited

Loading

radius-functional-tests Bot commented Oct 31, 2024 •

edited

Loading

lakshmimsft left a comment •

edited

Loading

radius-functional-tests Bot commented Nov 4, 2024 •

edited

Loading

radius-functional-tests Bot commented Nov 4, 2024 •

edited

Loading