Disabling cache in the setup-go steps of CI/CD by ytimocin · Pull Request #8147 · radius-project/radius

ytimocin · 2024-12-17T18:34:04Z

Description

Because the cache already exists on the GitHub runners we use, disabling cache in the setup-go steps of our CI/CD pipelines is expected solve the issue of seeing bunch of logs that say "cannot open: file exists".

The official documentation of setup-go and the part that is relevant: https://github.com/actions/setup-go#caching-dependency-files-and-build-outputs. This points out that setup-go does caching for us. If the cache is already there, we will get all the logs in our workflows.

There is no disadvantage of this approach, as far as I know, since the cache is already there. I actually ran into this comment that says that disabling cache in setup-go step improved the speed of the said step. We can always update our workflows if we see any other disadvantages.

Our runners: https://github.com/radius-project/radius/actions/runners.

References:

Type of change

This pull request fixes a bug in Radius and has an approved issue (issue link required).
Fixes: Run actions/cache@v4 step in functional tests spams thousands of log lines #7790

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

An overview of proposed schema changes is included in a linked GitHub issue.
A design document PR is created in the design-notes repository, if new APIs are being introduced.
If applicable, design document has been reviewed and approved by Radius maintainers/approvers.
A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.

github-actions · 2024-12-17T18:47:49Z

Unit Tests

3 554 tests ±0 3 550 ✅ ±0 5m 16s ⏱️ -1s
292 suites ±0 4 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit 45dc0b3. ± Comparison against base commit f714348.

♻️ This comment has been updated with latest results.

codecov · 2024-12-17T18:49:53Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.77%. Comparing base (f714348) to head (45dc0b3).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8147   +/-   ##
=======================================
  Coverage   59.76%   59.77%           
=======================================
  Files         590      590           
  Lines       39487    39487           
=======================================
+ Hits        23600    23603    +3     
+ Misses      14144    14142    -2     
+ Partials     1743     1742    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

radius-functional-tests · 2025-01-02T17:10:36Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	radius-project/radius
Commit ref	`233b9b8`
Unique ID	funcb9a1b17d76
Image tag	pr-funcb9a1b17d76

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcb9a1b17d76
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcb9a1b17d76
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funcb9a1b17d76
controller test image location: ghcr.io/radius-project/dev/controller:pr-funcb9a1b17d76
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcb9a1b17d76
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ corerp-cloud functional tests succeeded
✅ ucp-cloud functional tests succeeded

kachawla

Can you add some background in the description on why this change is being made, what are the drawbacks of disabling it?

radius-functional-tests · 2025-01-13T15:49:00Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	radius-project/radius
Commit ref	`39472db`
Unique ID	func1f40924ad2
Image tag	pr-func1f40924ad2

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func1f40924ad2
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func1f40924ad2
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func1f40924ad2
controller test image location: ghcr.io/radius-project/dev/controller:pr-func1f40924ad2
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func1f40924ad2
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

ytimocin · 2025-01-13T16:05:11Z

Can you add some background in the description on why this change is being made, what are the drawbacks of disabling it?

Updated the description.

Signed-off-by: ytimocin <ytimocin@microsoft.com>

radius-functional-tests · 2025-01-15T16:06:54Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	radius-project/radius
Commit ref	`45dc0b3`
Unique ID	func7d5909312b
Image tag	pr-func7d5909312b

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func7d5909312b
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func7d5909312b
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func7d5909312b
controller test image location: ghcr.io/radius-project/dev/controller:pr-func7d5909312b
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func7d5909312b
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

ytimocin requested review from a team as code owners December 17, 2024 18:34

ytimocin had a problem deploying to functional-tests December 17, 2024 18:35 — with GitHub Actions Failure

ytimocin temporarily deployed to publish-bicep December 17, 2024 18:35 — with GitHub Actions Inactive

ytimocin force-pushed the ytimocin/setup-go/disable-cache branch from 76d2fc6 to 233b9b8 Compare January 2, 2025 17:09

ytimocin temporarily deployed to functional-tests January 2, 2025 17:09 — with GitHub Actions Inactive

ytimocin temporarily deployed to publish-bicep January 2, 2025 17:09 — with GitHub Actions Inactive

kachawla reviewed Jan 2, 2025

View reviewed changes

ytimocin force-pushed the ytimocin/setup-go/disable-cache branch from 233b9b8 to 39472db Compare January 13, 2025 15:38

ytimocin temporarily deployed to functional-tests January 13, 2025 15:38 — with GitHub Actions Inactive

ytimocin temporarily deployed to publish-bicep January 13, 2025 15:38 — with GitHub Actions Inactive

Disabling cache in the setup-go steps of CI/CD

45dc0b3

Signed-off-by: ytimocin <ytimocin@microsoft.com>

ytimocin force-pushed the ytimocin/setup-go/disable-cache branch from 39472db to 45dc0b3 Compare January 14, 2025 18:13

ytimocin temporarily deployed to functional-tests January 14, 2025 18:13 — with GitHub Actions Inactive

ytimocin temporarily deployed to publish-bicep January 14, 2025 18:13 — with GitHub Actions Inactive

ytimocin requested a review from kachawla January 14, 2025 23:59

kachawla approved these changes Jan 15, 2025

View reviewed changes

ytimocin merged commit d56c866 into main Jan 15, 2025

ytimocin deleted the ytimocin/setup-go/disable-cache branch January 15, 2025 19:42

ytimocin mentioned this pull request Jan 24, 2025

Set cache option on setup-go action in workflows #8280

Merged

6 tasks

Navigation Menu

Repository navigation

Disabling cache in the setup-go steps of CI/CD - #8147

Disabling cache in the setup-go steps of CI/CD#8147
ytimocin merged 1 commit into
mainfrom
ytimocin/setup-go/disable-cache

ytimocin commented Dec 17, 2024 •

edited

Loading

Uh oh!

github-actions Bot commented Dec 17, 2024 •

edited

Loading

Uh oh!

codecov Bot commented Dec 17, 2024 •

edited

Loading

Uh oh!

radius-functional-tests Bot commented Jan 2, 2025 •

edited

Loading

Uh oh!

kachawla left a comment

Uh oh!

radius-functional-tests Bot commented Jan 13, 2025 •

edited

Loading

Uh oh!

ytimocin commented Jan 13, 2025

Uh oh!

radius-functional-tests Bot commented Jan 15, 2025 •

edited

Loading

Uh oh!

This branch was previously deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

ytimocin commented Dec 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

Contributor checklist

Uh oh!

github-actions Bot commented Dec 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unit Tests

Uh oh!

codecov Bot commented Dec 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

radius-functional-tests Bot commented Jan 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Radius functional test overview

Test Status

Uh oh!

kachawla left a comment

Choose a reason for hiding this comment

Uh oh!

radius-functional-tests Bot commented Jan 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Radius functional test overview

Test Status

Uh oh!

ytimocin commented Jan 13, 2025

Uh oh!

radius-functional-tests Bot commented Jan 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Radius functional test overview

Test Status

Uh oh!

This branch was previously deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ytimocin commented Dec 17, 2024 •

edited

Loading

github-actions Bot commented Dec 17, 2024 •

edited

Loading

codecov Bot commented Dec 17, 2024 •

edited

Loading

radius-functional-tests Bot commented Jan 2, 2025 •

edited

Loading

radius-functional-tests Bot commented Jan 13, 2025 •

edited

Loading

radius-functional-tests Bot commented Jan 15, 2025 •

edited

Loading