[sk593]

Description

The devcontainers dependabot update has been failing with the following error: Error during file fetching; aborting: Neither .devcontainer.json nor .devcontainer/devcontainer.json nor .devcontainer/<anything>/devcontainer.json found in /.devcontainer/contributor

It's looking in the .devcontainers/contributor folder for different paths but the paths that it's looking for are only valid from the root directory. This PR updates the directory to the root so it can locate the devcontainer.json file correctly.

Logs: https://github.com/radius-project/radius/actions/workflows/dependabot/dependabot-updates

Type of change

• This pull request fixes a bug in Radius and has an approved issue (issue link required).
• This pull request adds or changes features of Radius and has an approved issue (issue link required).
• This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Fixes: #issue_number

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

• An overview of proposed schema changes is included in a linked GitHub issue.
• A design document PR is created in the design-notes repository, if new APIs are being introduced.
• If applicable, design document has been reviewed and approved by Radius maintainers/approvers.
• A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
• A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
• A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.84%. Comparing base (c9f05c9) to head (1b801b1).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8239      +/-   ##
==========================================
+ Coverage   59.82%   59.84%   +0.01%     
==========================================
  Files         590      590              
  Lines       39513    39513              
==========================================
+ Hits        23639    23645       +6     
+ Misses      14114    14110       -4     
+ Partials     1760     1758       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[brooke-hamilton]

What do you think about removing the contributor folder path from the .devcontainer folder? I assume there was at one time an intent to create multiple dev containers within this repo, but that never materialized, so should we revert to the default path of .devcontainer/devcontainer.json?

[sk593]

What do you think about removing the contributor folder path from the .devcontainer folder? I assume there was at one time an intent to create multiple dev containers within this repo, but that never materialized, so should we revert to the default path of .devcontainer/devcontainer.json?

We can remove it if there's no plan to add another one. If there is a tracking issue somewhere to add more dev containers, I think we should keep it but not otherwise. It's pretty low effort to add it back in if we ever change our minds

[brooke-hamilton]

💯

[radius-functional-tests]

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	sk593/radius
Commit ref	1b801b1
Unique ID	funcbd20c42ff0
Image tag	pr-funcbd20c42ff0

Click here to see the list of tools in the current test run

• gotestsum 1.12.0
• KinD: v0.20.0
• Dapr:
• Azure KeyVault CSI driver: 1.4.2
• Azure Workload identity webhook: 1.3.0
• Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcbd20c42ff0
• Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
• applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcbd20c42ff0
• dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funcbd20c42ff0
• controller test image location: ghcr.io/radius-project/dev/controller:pr-funcbd20c42ff0
• ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcbd20c42ff0
• deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ corerp-cloud functional tests succeeded
✅ ucp-cloud functional tests succeeded