Skip to content

Consolidated Dependabot npm updates for Typespec - #8897

Merged
brooke-hamilton merged 3 commits into
radius-project:mainfrom
brooke-hamilton:dependabot-npm
Mar 18, 2025
Merged

brooke-hamilton merged 3 commits into
radius-project:mainfrom
brooke-hamilton:dependabot-npm

Conversation

@brooke-hamilton

@brooke-hamilton brooke-hamilton commented Mar 18, 2025 •

Copy link
Copy Markdown
Member

Description

Dependabot submitted multiple PRs below that affect the typespec code generation. They have to be taken as a group due to incompatibilities in their dependencies. This PR consolidates those PRs:

As part of this change, the features in @azure-tools/typespec-providerhub were moved into @azure-tools/typespec-azure-resource-manager, so I removed the typespec-providerhub imports from the affected files.

Running make generate results in no changes to the generated outputs.

I opened #8899 to track updates to the TypeSpec definitions to resolve deprecation warnings.

Type of change

  • This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Fixes: N/A

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

  • An overview of proposed schema changes is included in a linked GitHub issue.
    • Yes
    • Not applicable
  • A design document PR is created in the design-notes repository, if new APIs are being introduced.
    • Yes
    • Not applicable
  • The design document has been reviewed and approved by Radius maintainers/approvers.
    • Yes
    • Not applicable
  • A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
    • Yes
    • Not applicable
  • A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
    • Yes
    • Not applicable
  • A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.
    • Yes
    • Not applicable

Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
@codecov

codecov Bot commented Mar 18, 2025 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.90%. Comparing base (27191c2) to head (cea7b34).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8897   +/-   ##
=======================================
  Coverage   59.89%   59.90%           
=======================================
  Files         595      595           
  Lines       40481    40481           
=======================================
+ Hits        24248    24252    +4     
+ Misses      14406    14404    -2     
+ Partials     1827     1825    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@radius-functional-tests

radius-functional-tests Bot commented Mar 18, 2025 •

Copy link
Copy Markdown

Radius functional test overview

🔍 Go to test action run

Name Value
Repository brooke-hamilton/radius
Commit ref e595e44
Unique ID func371d22f9da
Image tag pr-func371d22f9da
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func371d22f9da
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func371d22f9da
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func371d22f9da
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func371d22f9da
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func371d22f9da
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

@radius-functional-tests

radius-functional-tests Bot commented Mar 18, 2025 •

Copy link
Copy Markdown

Radius functional test overview

🔍 Go to test action run

Name Value
Repository brooke-hamilton/radius
Commit ref cea7b34
Unique ID func0d95ffd4d4
Image tag pr-func0d95ffd4d4
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func0d95ffd4d4
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func0d95ffd4d4
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func0d95ffd4d4
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func0d95ffd4d4
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func0d95ffd4d4
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

@brooke-hamilton
brooke-hamilton merged commit 6ab3cd3 into radius-project:main Mar 18, 2025

This branch was previously deployed

2 inactive deployments
functional-tests — cea7b341 Deployed Mar 18, 2025 by brooke-hamilton
publish-bicep — cea7b341 Deployed Mar 18, 2025 by brooke-hamilton
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants