Repository navigation
Add golangci-lint to dev container - #9026
Conversation
Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9026 +/- ##
=======================================
Coverage 55.94% 55.94%
=======================================
Files 604 604
Lines 41466 41466
=======================================
Hits 23197 23197
+ Misses 16497 16496 -1
- Partials 1772 1773 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
| // Prerequisite for Code Generation, see https://github.com/radius-project/radius/tree/main/docs/contributing/contributing-code/contributing-code-prerequisites#code-generation | ||
| // Adding workspace as safe directory to avoid permission issues | ||
| "postCreateCommand": "git config --global --add safe.directory /workspaces/radius && cd typespec && npm ci && npm install -g autorest && npm install -g oav && go install sigs.k8s.io/controller-tools/cmd/controller-gen@v0.16.0 && go install go.uber.org/mock/mockgen@v0.4.0", | ||
| "postCreateCommand": ".devcontainer/post-create.sh", |
Description
While working on updating the go version there was a need to install the correct version of
golanglint-ci. The documentation recommends using a binary installation, so I added that to the devcontainer specification (devcontainer.json). As part of that change I moved thepostCreateCommandinto a script. I also fixed broken links togolanglint-ciin the Radius contributing docs.Development environment setup:
.devcontainer/devcontainer.json: Changed thepostCreateCommandto use a new script.devcontainer/post-create.shinstead of a long inline command..devcontainer/post-create.sh: Created a new script to handle post-create tasks, including setting up the workspace as a safe directory, installinggolangci-lint, and other Go tools.Documentation updates: fix broken links
docs/contributing/contributing-code/contributing-code-first-commit/first-commit-00-prerequisites/index.md: Updated the link forgolangci-lintinstallation to the welcome page.docs/contributing/contributing-code/contributing-code-first-commit/first-commit-06-creating-a-pr/index.md: Updated the link forgolangci-lintin the pre-PR checklist.docs/contributing/contributing-code/contributing-code-prerequisites/README.md: Updated the link forgolangci-lintin the list of core dependencies.Type of change
Fixes: N/A
Contributor checklist
Please verify that the PR meets the following requirements, where applicable: