Skip to content

Add golangci-lint to dev container - #9026

Merged
brooke-hamilton merged 5 commits into
radius-project:mainfrom
brooke-hamilton:golangci-lint
May 15, 2025
Merged

brooke-hamilton merged 5 commits into
radius-project:mainfrom
brooke-hamilton:golangci-lint

Conversation

@brooke-hamilton

Copy link
Copy Markdown
Member

Description

While working on updating the go version there was a need to install the correct version of golanglint-ci. The documentation recommends using a binary installation, so I added that to the devcontainer specification (devcontainer.json). As part of that change I moved the postCreateCommand into a script. I also fixed broken links to golanglint-ci in the Radius contributing docs.

Development environment setup:

  • .devcontainer/devcontainer.json: Changed the postCreateCommand to use a new script .devcontainer/post-create.sh instead of a long inline command.
  • .devcontainer/post-create.sh: Created a new script to handle post-create tasks, including setting up the workspace as a safe directory, installing golangci-lint, and other Go tools.

Documentation updates: fix broken links

Type of change

  • This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Fixes: N/A

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

  • An overview of proposed schema changes is included in a linked GitHub issue.
    • Yes
    • Not applicable
  • A design document PR is created in the design-notes repository, if new APIs are being introduced.
    • Yes
    • Not applicable
  • The design document has been reviewed and approved by Radius maintainers/approvers.
    • Yes
    • Not applicable
  • A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
    • Yes
    • Not applicable
  • A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
    • Yes
    • Not applicable
  • A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.
    • Yes
    • Not applicable

Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
@brooke-hamilton
brooke-hamilton requested review from a team as code owners March 30, 2025 21:43
@brooke-hamilton brooke-hamilton changed the title Golangci lint Add golangci-lint to dev container Mar 30, 2025
@radius-functional-tests

radius-functional-tests Bot commented Mar 30, 2025 •

Copy link
Copy Markdown

Radius functional test overview

🔍 Go to test action run

Name Value
Repository brooke-hamilton/radius
Commit ref db528a5
Unique ID funcc06e12d6f2
Image tag pr-funcc06e12d6f2
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcc06e12d6f2
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcc06e12d6f2
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funcc06e12d6f2
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-funcc06e12d6f2
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcc06e12d6f2
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

@codecov

codecov Bot commented Mar 30, 2025 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.94%. Comparing base (6b7aa81) to head (fe1835f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9026   +/-   ##
=======================================
  Coverage   55.94%   55.94%           
=======================================
  Files         604      604           
  Lines       41466    41466           
=======================================
  Hits        23197    23197           
+ Misses      16497    16496    -1     
- Partials     1772     1773    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@radius-functional-tests

radius-functional-tests Bot commented May 15, 2025 •

Copy link
Copy Markdown

Radius functional test overview

🔍 Go to test action run

Name Value
Repository brooke-hamilton/radius
Commit ref fe1835f
Unique ID func2711d7da9d
Image tag pr-func2711d7da9d
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func2711d7da9d
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func2711d7da9d
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func2711d7da9d
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func2711d7da9d
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func2711d7da9d
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

// Prerequisite for Code Generation, see https://github.com/radius-project/radius/tree/main/docs/contributing/contributing-code/contributing-code-prerequisites#code-generation
// Adding workspace as safe directory to avoid permission issues
"postCreateCommand": "git config --global --add safe.directory /workspaces/radius && cd typespec && npm ci && npm install -g autorest && npm install -g oav && go install sigs.k8s.io/controller-tools/cmd/controller-gen@v0.16.0 && go install go.uber.org/mock/mockgen@v0.4.0",
"postCreateCommand": ".devcontainer/post-create.sh",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@brooke-hamilton
brooke-hamilton merged commit 3afdd83 into radius-project:main May 15, 2025

This branch was previously deployed

2 inactive deployments
publish-bicep — fe1835f4 Deployed May 15, 2025 by brooke-hamilton
functional-tests — fe1835f4 Deployed May 15, 2025 by brooke-hamilton
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants