Repository navigation
Updating rad version command to also show control plane version - #9167
Conversation
GitHub Actions
Inactive
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9167 +/- ##
==========================================
+ Coverage 55.84% 55.98% +0.13%
==========================================
Files 603 604 +1
Lines 41344 41466 +122
==========================================
+ Hits 23090 23216 +126
+ Misses 16486 16484 -2
+ Partials 1768 1766 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| // writeVersionInfo displays both CLI and Control Plane version information | ||
| func (r *Runner) writeVersionInfo(format string) error { | ||
| // Display CLI version information | ||
| cliVersion := struct { |
There was a problem hiding this comment.
lots of dup code here. MIght be best to move this to a builder or helper method to keep thing DRY
brooke-hamilton
left a comment
brooke-hamilton
left a comment
There was a problem hiding this comment.
I get an error when running rad version when not connected to a radius installation. Maybe just a message saying control plane not connected or something similar.
CLI Version Information:
RELEASE VERSION BICEP COMMIT
edge v0.45.0-rc1-11-gbaab250 0.33.93 baab250fd813b4fcdb57717a0f4acec929d1ab7a
Failed to check Radius control plane: Kubernetes cluster unreachable: Get "http://localhost:8080/version": dial tcp 127.0.0.1:8080: connect: connection refused
Control Plane Information:
VERSION DAPR VERSION
Not installed Not installedAlso this when running rad version --output json
$ rad version --output json
CLI Version Information:
{
"release": "edge",
"version": "v0.45.0-rc1-11-gbaab250",
"bicep": "0.33.93",
"commit": "baab250fd813b4fcdb57717a0f4acec929d1ab7a"
}
Failed to check Radius control plane: Kubernetes cluster unreachable: Get "http://localhost:8080/version": dial tcp 127.0.0.1:8080: connect: connection refused
Control Plane Information:
{
"version": "Not installed",
"daprVersion": "Not installed"
}Signed-off-by: ytimocin <ytimocin@microsoft.com>
baab250 to
324fb1d
Compare
GitHub Actions
Failure
Signed-off-by: ytimocin <ytimocin@microsoft.com>
GitHub Actions
Failure
brooke-hamilton
left a comment
brooke-hamilton
left a comment
There was a problem hiding this comment.
🚀 Looks great:
$ rad version
CLI Version Information:
RELEASE VERSION BICEP COMMIT
edge v0.46.0-8-gf7b0f3a 0.35.1 f7b0f3a39769393566c450e3c151de5fdb6b53cb
Control Plane Information:
STATUS VERSION
Installed 0.46.0
$ rad version -o json
{
"release": "edge",
"version": "v0.46.0-8-gf7b0f3a",
"bicep": "0.35.1",
"commit": "f7b0f3a39769393566c450e3c151de5fdb6b53cb"
}
{
"version": "0.46.0",
"status": "Installed"
}
willtsai
left a comment
willtsai
left a comment
There was a problem hiding this comment.
minor nitpicks but otherwise looks good to me
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
c2b221a to
5f8f844
Compare
The base branch was changed.
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Co-authored-by: Will <28876888+willtsai@users.noreply.github.com> Signed-off-by: Yetkin Timocin <ytimocin@gmail.com> Signed-off-by: ytimocin <ytimocin@microsoft.com>
5f8f844 to
ae24b04
Compare
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Description
Updating rad version command to also show control plane version:
Type of change
Fixes: #8953
Contributor checklist
Please verify that the PR meets the following requirements, where applicable: