Skip to content

fix: preserve literal translation replacement values - #2714

Open
lfhwnqe wants to merge 1 commit into
rainbow-me:mainfrom
lfhwnqe:fix/literal-translation-values
Open

lfhwnqe wants to merge 1 commit into
rainbow-me:mainfrom
lfhwnqe:fix/literal-translation-values

Conversation

@lfhwnqe

@lfhwnqe lfhwnqe commented Nov 5, 2026

Copy link
Copy Markdown

Translated connection messages corrupt wallet/application names containing JavaScript replacement sequences. For example, inserting Wallet $& into Connect %{wallet} produces Connect Wallet %{wallet} instead of preserving the wallet name.

Use a replacement callback so interpolation values remain literal. Add regressions for JavaScript's match, literal-dollar, prefix and suffix replacement sequences, plus locale fallback handling.

Validation: all five new regressions fail on the base commit and pass with the fix. The I18n suite passes all 16 tests. Full suite: 25 files passed, 1 skipped; 153 tests passed, 2 expected failures, 1 skipped. The RainbowKit package build, workspace lint/format/type checks, and git diff --check pass. Patch changeset included. No matching existing issue or PR was found.

AI assistance: OpenAI Codex assisted with reproduction, implementation, tests, and this description.

@vercel

vercel Bot commented Nov 5, 2026

Copy link
Copy Markdown

@lfhwnqe is attempting to deploy a commit to the rainbowdotme Team on Vercel.

A member of the Team first needs to authorize it.

@changeset-bot

changeset-bot Bot commented Nov 5, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 98c5173

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@rainbow-me/rainbowkit Patch
example Patch
@rainbow-me/rainbow-button Patch
rainbowkit-next-app Patch
site Patch
with-create-react-app Patch
with-next-app-i18n Patch
with-next-app Patch
with-next-custom-button Patch
with-next-mint-nft Patch
with-next-siwe-iron-session Patch
with-next-siwe-next-auth Patch
with-next-wallet-button Patch
with-next Patch
with-react-router Patch
with-remix Patch
with-vite Patch
with-next-rainbow-button Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-05T07:22:36.495070Z 98c5173 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant