Repository navigation
fix: upgrade cuer to 0.0.4 - #2716
chayan-bit wants to merge 1 commit into
Conversation
cuer 0.0.3 renders the WalletConnect QR code with qr's encodeQR and border: 0. qr 0.6.0 rejects border <= 0, and cuer depends on qr ~0, so any install that resolves qr 0.6 or newer throws 'invalid border=0' and unmounts the modal. cuer 0.0.4 encodes with border: 1 and slices it off, producing the same grid. Fixes rainbow-me#2677
|
@chayan-bit is attempting to deploy a commit to the rainbowdotme Team on Vercel. A member of the Team first needs to authorize it. |
🦋 Changeset detectedLatest commit: 428e112 The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Fixes #2677.
Summary
Upgrades
cuerfrom 0.0.3 to 0.0.4 in@rainbow-me/rainbowkitand in the example app.cuer@0.0.3builds the WalletConnect QR code withencodeQR(value, 'raw', { border: 0, ... })and depends onqr: ~0.qr@0.6.0(2026-04-28) rejectsborder <= 0, so any app whose install resolvesqr0.6 or newer (0.7.2 today) throwsRangeError: invalid border=0as soon as the WalletConnect QR renders, and the error unmounts the app.cuer@0.0.4(wevm/cuer#11, fixing wevm/cuer#12) encodes withborder: 1and slices that ring off, so the grid is unchanged; its API and types are identical to 0.0.3.This repo's lockfile pins
qr@0.4.2, which is why CI and local development never hit the crash; consumers installing RainbowKit 2.2.11 fresh do.This supersedes the
qrpin in #2678, which describes itself as a workaround until cuer#11 is released.Demo
Before and after in
packages/example, Connect Wallet then WalletConnect, withqr@0.7.2installed as consumers resolve it (45 s): https://github.com/chayan-bit/rainbowkit/blob/demo-assets/cuer-qr-fix.mp4cuer@0.0.3):Runtime RangeError: invalid border=0fromencodeQR, and the page goes blank.cuer@0.0.4): the QR code renders.Testing
pnpm install --frozen-lockfilewith the updated lockfile (only thecuerentries change).pnpm lintandpnpm test: 148 passed, 2 expected fail, 1 skipped.cuer@0.0.4withqr@0.7.2produces a grid byte-identical tocuer@0.0.3withqr@0.5.5for the same WalletConnect URI, so wallets scan the same code as before theqrchange.