fix product structured data on pdp#1302
Open
JimmyHoenderdaal wants to merge 3 commits into
Open
Conversation
Jade-GG
requested changes
Jun 2, 2026
Jade-GG
approved these changes
Jun 10, 2026
royduin
reviewed
Jun 30, 2026
Comment on lines
+4
to
+6
| @if ($product->description) | ||
| <meta itemprop="description" content="{{ str($product->description)->stripTags()->squish() }}" /> | ||
| @endif |
Member
There was a problem hiding this comment.
With this we do get the product description twice in the source
royduin
reviewed
Jun 30, 2026
| <meta itemprop="url" content="{{ url($product->url) }}" /> | ||
| @if ($product->special_to_date && $product->special_to_date > now()->toDateTimeString()) | ||
| <meta itemprop="priceValidUntil" content="{{ $product->special_to_date }}" /> | ||
| <meta itemprop="priceValidUntil" content="{{ str($product->special_to_date)->before(' ')->before('T') }}" /> |
royduin
reviewed
Jun 30, 2026
| <span itemprop="name">{{ $slot }}</span> | ||
| <meta itemprop="position" content="{{ $position }}" /> | ||
| </a> | ||
| <meta itemprop="item" content="{{ url($url) }}" /> |
Member
There was a problem hiding this comment.
With this we do get the url twice? I don't see how this is an improvement, can you explain?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Product pages rendered Product microdata, but the core Product fields were split over visible markup. That made the structured data harder to validate and easier to duplicate when other packages add their own microdata.
This keeps the Product fields in one place:
nameand a plain-textdescriptionto the PDP microdata partialitempropfrom the visible PDP title and descriptionitemConditionto the OfferpriceValidUntilas a date-only valueitemmeta tagReview microdata stays in
rapidez-reviews.Tests
git diff --check origin/master...feature/pdp-rich-snippetsReference
RAP-1899