ggml-openvino : support ggml_rope_set_offset and simplify op support gating - #304
Open
mostafafaheem wants to merge 2 commits into
Open
ggml-openvino : support ggml_rope_set_offset and simplify op support gating#304mostafafaheem wants to merge 2 commits into
mostafafaheem wants to merge 2 commits into
Conversation
cavusmustafa
reviewed
Sep 1, 2026
| } | ||
| case GGML_OP_CPY: { | ||
| if (op->src[0]->type == GGML_TYPE_BF16 || op->src[1]->type == GGML_TYPE_BF16) { | ||
| if (op->src[0]->type != GGML_TYPE_BF16 && op->src[1]->type == GGML_TYPE_BF16) { |
Collaborator
There was a problem hiding this comment.
Seems like this lets CPY to pass if src[0] is bf16, is that right? Is the conversion handled in frontend or openvino core if bf16 not supported on target device?
src[0] |
src[1] |
before | after |
|---|---|---|---|
| BF16 | BF16 | true | false |
| BF16 | not BF16 | true | false |
| not BF16 | BF16 | true | true |
| not BF16 | not BF16 | false | false |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Additional information
Supported ROPE cases went from 176 -> 280
Requirements