Repository navigation
[T3 Code] Open threads by ID on supported desktops - #33158
Conversation
|
Thank you for your first contribution! 🎉 🔔 @Skilux you might want to have a look. You can use this guide to learn how to check out the Pull Request locally in order to test it. 📋 Quick checkout commandsBRANCH="fix/t3-code-thread-deep-links"
FORK_URL="https://github.com/ikazoy/extensions.git"
EXTENSION_NAME="t3-code"
REPO_NAME="extensions"
git clone -n --depth=1 --filter=tree:0 -b $BRANCH $FORK_URL
cd $REPO_NAME
git sparse-checkout set --no-cone "extensions/$EXTENSION_NAME"
git checkout
cd "extensions/$EXTENSION_NAME"
npm install && npm run devWe're currently experiencing a high volume of incoming requests. As a result, the initial review may take up to 15 business days. |
[Medium impact] No blocking issue remains from this follow-up review. SummaryThe PR opens threads by environment and thread ID on supported T3 Code desktops.
No new actionable issues were found. Reviews (4) · Last reviewed commit: "Update CHANGELOG.md" · Reviewed by Greptile |
0xdhrv
left a comment
There was a problem hiding this comment.
Hey @ikazoy 👋
Thanks for your contribution 🔥 The deep-link path is a nice fix: version-gated t3code://threads/<environmentId>/<threadId> on supported desktops, with the command-palette fallback kept for older installs, and the README now describes that clearly. Thanks also for dropping the npm test paragraph after Greptile's note.
Here's everything I found in this pass:
Blocking
- Please remove
tests/thread-links.test.tsfrom the extension folder and keep it in your own repo. Store installs only need the extension itself plusREADME.md,CHANGELOG.md,media/andmetadata/. - Please also drop the
testscript frompackage.json. There are no extra test devDependencies to remove.
As mentioned in our docs here ↗
Pre-existing on main, not from this PR, no action needed: the README still has a Development section (npm install / npm run dev).
When the blocking items are done, request another review 😊
Feel free to reach me here or on Slack if anything is unclear.
|
Thanks for the review! Removed One small documentation suggestion for future contributors: a short note in the contribution guide about where test files and test scripts should live could be helpful. The test file was absent from the distribution output I checked, so distinguishing the source-submission layout from the packaged files would make the expectation easier to follow. This is ready for another review. Thanks! |
|
Published to the Raycast Store: |
|
🎉 🎉 🎉 Such a great contribution deserves a reward, but unfortunately we couldn't find your Raycast account based on your GitHub username (@ikazoy). Please link your GitHub account to your Raycast account to receive your credits and soon be able to exchange them for some swag. |
Description
Selecting Open in T3 Code can leave the command palette showing no results even when the selected thread exists. The extension types
<title> <project> <branch>, but recent T3 Code searches branches without theirt3/ort3code/prefix. For example,sync sample data sample-project t3/run-syncfails to match the thread; the title alone or the query withoutt3/matches. Non-ASCII titles can also be corrupted by the AppleScript keystroke path.This change opens the exact thread with
t3code://threads/<environmentId>/<threadId>on supported desktops. It reads the selected desktop app's bundle version rather than assuming a custom server's version describes the local app. Stable 0.1.0+ and known supported Nightly builds use the link; older/unknown desktop versions, unavailable bundle metadata, or missing environment IDs keep the existing palette path. ID segments are encoded separately. All three commands use the sharedfocusThreadimplementation.Reproduction and version evidence
T3 Code (Beta)in the test environment).t3/branch, such as titlesync sample data, projectsample-project, brancht3/run-sync.The synthetic example was also checked against T3's actual search functions: v0.1.2 matches it; v0.1.3 introduced the prefix-stripping search behavior (T3 #24343); v0.1.7 does not match it. A branch without the reserved prefix still matches. These older-version checks are source-level execution, not tests of installed older desktop apps.
Thread deep links were added in T3 #18454, before stable v0.1.0. The known Nightly boundary is
0.0.46-nightly.20261012.3010.Validation
npm run build: passes.npm run lint: passes, including manifest, assets, metadata, ESLint and formatting checks.t3/branches opened the correct existing thread.Older desktop apps and Nightly apps were not installed for manual testing. Their fallback/selection behavior is covered by the compatibility tests. No new dependency is needed.
Screencast
No new commands or UI; existing thread navigation is corrected. Manual distribution-build checks are described above.
Checklist
npm run buildand tested this distribution build in Raycastassetsfolder are used by the extension itselfREADMEare located outside the metadata folder if they were not generated with our metadata tool