Skip to content

fix(sdk): remove orgId from project update requests - #1604

Merged
rohilsurana merged 4 commits into
mainfrom
fix/stop-sending-orgid-project-update
May 13, 2026
Merged

fix(sdk): remove orgId from project update requests#1604
rohilsurana merged 4 commits into
mainfrom
fix/stop-sending-orgid-project-update

Conversation

@rohilsurana

Copy link
Copy Markdown
Member

Summary

  • Remove orgId field from project update request bodies in the frontend SDK
  • Applies to both the client-side edit project dialog (views-new) and the admin rename project dialog
  • Backend already enforces org immutability on UpdateProject (f4d3398), so sending orgId is unnecessary

Test plan

  • Login to client-demo, edit a project name — verify update succeeds without errors
  • Login to admin UI, rename a project — verify rename succeeds without errors
  • Verify network tab shows no orgId in the UpdateProject request body

@vercel

vercel Bot commented May 13, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
frontier Ready Ready Preview, Comment May 13, 2026 8:30am

@coderabbitai

coderabbitai Bot commented May 13, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Rate limit exceeded

@rohilsurana has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 2 minutes and 37 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 2f9373d0-9205-4830-b611-95e013e30281

📥 Commits

Reviewing files that changed from the base of the PR and between c8ce0fe and b4f52ae.

⛔ Files ignored due to path filters (1)
  • web/pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (4)
  • web/apps/admin/package.json
  • web/sdk/package.json
  • web/sdk/react/views-new/projects/project-details-view.tsx
  • web/sdk/react/views-new/teams/team-details-view.tsx
📝 Walkthrough

Walkthrough

Two project management components are updated to stop including organization ID in update requests. The rename dialog's form validation schema and defaults are simplified to exclude orgId, and the edit dialog removes its Frontier context dependency while updating the request payload construction to match this change.

Changes

Remove organization ID from project update requests

Layer / File(s) Summary
Form schema validation updates
web/sdk/admin/views/organizations/details/projects/rename-project.tsx
projectRenameSchema Zod object and useForm defaultValues are updated to remove the orgId field, dropping it from form validation and initialization.
Dialog component and request payload
web/sdk/react/views-new/projects/components/edit-project-dialog.tsx
Module imports remove Frontier context dependency, form setup stops deriving activeOrganization, and onSubmit removes the organization ID presence check while constructing UpdateProjectRequestSchema requests containing only the project title.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • raystack/frontier#1598: The main PR's frontend removal of the orgId field from the updateProject request payload directly matches the backend/proto change in PR #1598 where UpdateProjectRequestBody (and handler/repo parsing) now omits org_id and treats project org as immutable.

Suggested reviewers

  • rsbh
  • paanSinghCoder
  • rohanchkrabrty
🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@rohilsurana
rohilsurana marked this pull request as ready for review May 13, 2026 07:32
@coveralls

coveralls commented May 13, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 25787721217

Coverage remained the same at 42.291%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 37542
Covered Lines: 15877
Line Coverage: 42.29%
Coverage Strength: 11.9 hits per line

💛 - Coveralls

@rohilsurana
rohilsurana merged commit bb2091e into main May 13, 2026
8 checks passed
@rohilsurana
rohilsurana deleted the fix/stop-sending-orgid-project-update branch May 13, 2026 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants