Skip to content

fix(admin): open billing portal in same tab to reflect edits on return #1722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rohilsurana merged 1 commit into from
Jul 1, 2026
Merged

fix(admin): open billing portal in same tab to reflect edits on return #1722

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 2 additions & 12 deletions web/sdk/admin/views/organizations/details/side-panel/billing-details-section.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,11 +56,6 @@ export const BillingDetailsSection = () => {
const handleOpenBillingPortal = async () => {
if (isBillingPortalDisabled) return;
const returnUrl = window.location.href;
// Open the tab synchronously within the click gesture so popup blockers
// allow it; it is navigated once the portal URL is ready. Opened without
// "noopener" so we can set its location, then opener is severed for safety.
const portalTab = window.open("", "_blank");
if (portalTab) portalTab.opener = null;
try {
const resp = await createCheckout(
create(CreateCheckoutRequestSchema, {
Expand All @@ -71,16 +66,11 @@ export const BillingDetailsSection = () => {
})
);
const checkoutUrl = resp?.checkoutSession?.checkoutUrl;
if (checkoutUrl && portalTab) {
portalTab.location.href = checkoutUrl;
} else if (checkoutUrl) {
window.open(checkoutUrl, "_blank", "noopener,noreferrer");
} else {
portalTab?.close();
if (checkoutUrl) {
window.location.href = checkoutUrl;
}
} catch {
// the error toast is surfaced by the mutation's onError handler
portalTab?.close();
}
};

Expand Down
Loading