Conversation
Signed-off-by: Raushan Kumar <raus7n@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the unnecessary JSON marshal/unmarshal round trip from the Go IFSC validation path.
getDatanow normalizes the branch suffix directly and returns aDatavalue instead of serializing and deserializing it.Why
The previous implementation performed JSON marshaling and unmarshaling during every validation call even though the input was already available as a string.
This change removes unnecessary serialization work and allocations while preserving existing validation behavior.
Testing
go test ./src/go -run Validate -vpasses.go test ./...still hits the existingTestLookUP/successnil-pointer panic on unmodifiedmaster, so that failure is unrelated to this change.Test Case Document URL
Not added. The
Testedlabel is not being used for this PR.