dropbox: propagate caller contexts to SDK requests - #9712
Merged
Merged
Conversation
8 tasks
ncw
approved these changes
Aug 1, 2026
ncw
left a comment
ncw
left a comment
Member
There was a problem hiding this comment.
This looks great - thank you :-)
The regression test is a nice touch.
I verified there are no remaining non-context SDK calls in the package, and build, vet and the unit tests all pass locally. CI is green.
One small thing I will tidy when merging: the commit summary should be user-facing and reference the issue, per CONTRIBUTING.md, e.g. "dropbox: fix Ctrl-C and --max-duration not stopping in-flight requests - fixes #9688". Nothing needed from you on that.
Member
|
Can you fix the conflict for this (maybe update the commit message while you are doing so?) Thank you |
DebadityaHait
force-pushed
the
fix/dropbox-context-cancellation
branch
from
August 1, 2026 14:51
ae9aedd to
590e1e5
Compare
Member
|
Thank you :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9688.
Switch the Dropbox backend’s stored SDK clients to their context-aware variants and pass caller contexts through the API call sites.
Batch upload finalization continues to use its independently owned batcher context, so its lifecycle is unchanged. Add a regression test that verifies an in-flight metadata request returns promptly when its caller context is cancelled.
Tests:
go test -count=1 -v ./backend/dropbox(including realTestDropboxintegration)go test -count=1 -run '^TestInternalGetMetadataCancellation$' ./backend/dropboxgo build