RCTConvert.h yoga/Yoga.h file not found

[adamgins]

I am logging this as a bug as it seems like a bunch of people have logged it as an issue on Stackoverflow ... but seems to be a bug http://stackoverflow.com/questions/41505616/yoga-yoga-h-header-file-not-found-after-react-native-integration-in-the-existing

Upgraded to latest react-native 0.4.0

Build project for iOS on Xcode and you get the error message: /Users/adamginsburg/Documents/development/buzzy9/node_modules/react-native/React/Base/RCTConvert.h:13:9: 'yoga/Yoga.h' file not found

• React Native version: 0.4.0
• Platform: iOS
• Operating System: The build issue happen on XCode 8

[adamgins]

Is this the reason? https://github.com/facebook/react-native/releases/tag/v0.40.0

[fgaleano]

I'm getting similar error messages. In my case:

• 'React/RCTConvert.h' file not found in RCTResizeMode.h
• 'React/RCTLog.h' file not found in RCTNetworkTask.m

I had like 5-6 more but those went away after I deleted my node_modules folders and ran npm install. These 2 remained, though, and my app won't build.

What are we missing?

[julienfouilhe]

I am using react native in an already existing iOS app. Everything is working fine with 0.39.0.

When I tried updating to 0.40.0, I get this error message when compiling (RCTConvert.h yoga/Yoga.h file not found)

@emilsjolander

[emilsjolander]

Seems like the xcode project needs to be fixed in some way. Not really sure what could have broken this. @mmmulani Could you have a look?

[JesseARWhite]

This looks like it has something to do with Cocoapods integration, @julienfouilhe @emilsjolander can you confirm if this is coming from cocoapods or not?

[julienfouilhe]

@JesseARWhite I am using CocoaPods yes, but I don't know if it is responsible for the error or not. XCode is giving the error when trying to build the app.

[robhogan]

I think this is the same issue we had in #9544, and occurs whenever use_frameworks is enabled - essentially a framework can't include its own internal headers using angle brackets.

Because FB needed to use angle brackets for its internal builds of CSS Layout @alloy proposed a compromise which was removed in 7c91f89 . Since the move to using angle brackets everywhere, the use of RN as a framework now looks pretty much beyond repair.

AFAIK it's still possible even in a swift project to disable use_frameworks and import RN via a bridging header. It should also be possible to find+replace imports in post_install, but that's really only a brittle hack if RN has dropped support for frameworks.

[julienfouilhe]

@rh389 I'm using swift and not using use_frameworks! would be painful, wouldn't it? Some of my dependencies are written in Swift.

What would need to be done in a post_install script? Changing <yoga/Yoga.h> for "yoga/Yoga.h"did not help, even when I added: ${SRCROOT}/../ios-editor/node_modules/react-native/ReactCommon to the User Header Search Paths of my project

[mmmulani]

cc @javache can you reapply for fix for the include header to yoga now?

[mmmulani]

hey everyone, I tried to repro this issue by creating a tiny project and following the Obj-C guide here: https://facebook.github.io/react-native/docs/integration-with-existing-apps.html
but I was not able to run into the Yoga build problem.

does anyone have a smaller repro case they could post?

[robhogan]

I'll see if I can post a repro case tomorrow, I did reproduce the issue earlier - in the meantime have you tried enabling use_frameworks, even in Objective-C? I haven't yet been able to get that working as a minimal build in a new app at all without modifying RN.

Edit: (Back at the mac) - repro case now up

git clone https://github.com/rh389/rn-framework-demo
cd rn-framework-demo
yarn install
open FrameworkDemo.xcworkspace

That was created simply by creating a new single-page ObjC app with the XCode wizard, then yarn add react-native react, adding a Podfile as in the repo, and pod install.

Attempting to build that in XCode should allow you to reproduce the yoga/Yoga.h not found immediate issue. It is possible to add [...]/ReactCommon recursive to the project's header search paths in order for Yoga.h to be found, but then the issue is eg #import <yoga/Yoga.h>: RCTConvert.h:13:9: Include of non-modular header inside framework module 'React.RCTConvert' - that's the more fundamental problem once you've got beyond search paths - as discussed in #9544 (and as far as I understand it - no expert) framework modules can have dependencies on their own internal headers or on other framework modules, but not on arbitrary, potentially external libraries.

I don't know of a way to overcome this while the #import style is what it is across RN.

[julienfouilhe]

Hi @mmmulani I also created a simple swift project, with all the files already in the repo, so all you have to do is launch the xcworkspace in xcode and try to build: https://github.com/julienfouilhe/test-yoga-file-not-found

Thanks!

What is weird too is the directories architecture:

[mmmulani]

@javache and I found a workaround to this problem and we'd like someone from the community to champion it and support it going forward.

we created a yoga.podspec at node_modules/react-native/ReactCommon/yoga with contents:

Pod::Spec.new do |s|
  s.name                = "yoga"
  s.source_files = '**/*.{c,h}'
  s.header_dir   = 'yoga'
  s.platform            = :ios, "8.0"
  s.author = ''
  s.license = 'a'
  s.homepage = 'a'
  s.source = { :path => '.' }
  s.summary = 'a'
  s.version = '0.1'
end

and then include it from the main Podfile with pod 'yoga', :path => './node_modules/react-native/ReactCommon/yoga'

you would have to make another one for jschelpers and possibly any other subspec we have that uses a different header search path.

but this seems like a bug in CocoaPods, it should let use create the React dependency and link all its subspecs statically but create the whole React dependency as a dylib. cc @alloy for any ideas here

[Aleksandern]

@mmmulani
It looks like it doesn't work in my case
I still have have an error

RCTConvert.h:13:9: fatal error: 'yoga/Yoga.h' file not found
#import <yoga/Yoga.h>

Podfile

platform :ios, '8.0'
use_frameworks!

target 'app' do
pod 'React', path: '../node_modules/react-native', :subspecs => [
'Core',
'RCTActionSheet',
'RCTAnimation',
'RCTGeolocation',
'RCTImage',
'RCTLinkingIOS',
'RCTNetwork',
'RCTSettings',
'RCTText',
'RCTVibration',
'RCTWebSocket'
]
`pod 'yoga', :path => '../node_modules/react-native/ReactCommon/yoga'
end

But I had to change pod 'yoga', :path => './node_modules/react-native/ReactCommon/yoga' to pod 'yoga', :path => '../node_modules/react-native/ReactCommon/yoga'

"react": "15.4.2",
"react-native": "0.40.0",