Repository navigation
DatePickerIOS - locale props not working #17696
Description
Activity
- changed the title
[-]DatDatePickerIOS - locale not working[/-][+]DatePickerIOS - locale not working[/+]on Jan 22, 2018 - changed the title
[-]DatePickerIOS - locale not working[/-][+]DatePickerIOS - locale props not working[/+]on Jan 22, 2018 @hramos Need your help
Confirm
localeprop doesn't work. React 16.2.0, react-native 0.51.0Confirming as well. React 16.2.0, react-native 0.51.0.
I think I know what causes this problem.
will try to submit a PR in the coming daysActually just realized today that they've fixed this issue in 0.52.0. Upgraded (or rather re-initiated and ported, upgrade process was hell) and now it works.
@404sand808s
yep confirmed this issue was fixed at 0.52.0 releaseThanks for posting this! It looks like you may not be using the latest version of React Native, v0.53.0, released on January 2018. Can you make sure this issue can still be reproduced in the latest version?
I am going to close this, but please feel free to open a new issue if you are able to confirm that this is still a problem in v0.53.0 or newer.
- This message was created automatically by mail delivery software. A message that you sent could not be delivered to one or more of its recipients. This is a temporary error. The following address(es) deferred: mkdirenv@gmail.com Domain salmanwaheed.info has exceeded the max emails per hour (151/150 (100%)) allowed. Message will be reattempted later…------- This is a copy of the message, including all the headers. ------ Received: from github-smtp2-ext3.iad.github.net ([192.30.252.194]:40333 helo=github-smtp2b-ext-cp1-prd.iad.github.net) by box1177.bluehost.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from <noreply@github.com>) id 1epQUk-003Ihj-DS for hello@salmanwaheed.info; Fri, 23 Feb 2018 20:27:30 -0700 Date: Fri, 23 Feb 2018 19:23:32 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1519442837; bh=BBzx2DFt0OG3z6oRThBwXn0y4dxfgSsLxhEmYktLxbs=; h=From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=fs/VcuuZ0znyvR1uEQBeS4Px1wPsf+vnLlUiHChqstzwX78CrknQ7KNRuzlPJIU/D BSwXCd1/0Y6Fl9dnFAyl+JT3g2/Q0jSHaEPUtq8RMmvQS79ismXTmzIJvcjIOBBh+w uNvGjG37OA/e8jjLZCWeoVPVVDd5/tlk+axt+JPI= From: React Native Bot <notifications@github.com> Reply-To: facebook/react-native <reply@reply.github.com> To: facebook/react-native <react-native@noreply.github.com> Cc: Subscribed <subscribed@noreply.github.com> Message-ID: <facebook/react-native/issue/17696/issue_event/1490267779@github.com> In-Reply-To: <facebook/react-native/issues/17696@github.com> References: <facebook/react-native/issues/17696@github.com> Subject: Re: [facebook/react-native] DatePickerIOS - locale props not working (#17696) Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_5a90dab4ea6de_1ee22acda0a3cecc4601d3"; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list X-GitHub-Sender: react-native-bot X-GitHub-Recipient: salmanwaheed X-GitHub-Reason: subscribed List-ID: facebook/react-native <react-native.facebook.github.com> List-Archive: https://github.com/facebook/react-native List-Post: <mailto:reply@reply.github.com> List-Unsubscribe: <mailto:unsub+00ef1b383f88d590bdeaaee1bd70b84b79ed3d619e4b1c4292cf0000000116a89cb492a169ce114f6811@reply.github.com>, <https://github.com/notifications/unsubscribe/AO8bOBMIMUBz_IzuothV-RknTJNm_zy6ks5tX4C0gaJpZM4RmdAJ> X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: hello@salmanwaheed.info X-Spam-Status: No, score=0.8 X-Spam-Score: 8 X-Spam-Bar: / X-Ham-Report: Spam detection software, running on the system "box1177.bluehost.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see root\@localhost for details. Content preview: Closed #17696. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: #17696 (comment) [...] Content analysis details: (0.8 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: github.com] -0.5 SPF_PASS SPF: sender matches SPF record 1.3 HTML_IMAGE_ONLY_24 BODY: HTML: images with 2000-2400 bytes of words 0.0 HTML_MESSAGE BODY: HTML included in message 2.5 DCC_CHECK No description available. -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -2.3 AWL AWL: Adjusted score from AWL reputation of From: address X-Spam-Flag: NO----==_mimepart_5a90dab4ea6de_1ee22acda0a3cecc4601d3 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Closed #17696.-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: #17696 (comment) ----==_mimepart_5a90dab4ea6de_1ee22acda0a3cecc4601d3 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit <p>Closed <a href="#17696" class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="290416657" data-permission-text="Issue title is private" data-url="#17696> <p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="#17696 (comment) it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AO8bOCyaH7AG9ChyE75Q7lINg_vfOf-Nks5tX4C0gaJpZM4RmdAJ">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AO8bOOnGyimYbTO7lCv5jTo4m5hvv5pgks5tX4C0gaJpZM4RmdAJ.gif" width="1" /></p> <div itemscope itemtype="http://schema.org/EmailMessage"> <div itemprop="action" itemscope itemtype="http://schema.org/ViewAction"> <link itemprop="url" href="#17696 (comment)> <meta itemprop="name" content="View Issue"></meta> </div> <meta itemprop="description" content="View this Issue on GitHub"></meta> </div> <script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/facebook/react-native","title":"facebook/react-native","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/facebook/react-native"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Closed #17696."}],"action":{"name":"View Issue","url":"#17696 (comment)> ----==_mimepart_5a90dab4ea6de_1ee22acda0a3cecc4601d3--
- This message was created automatically by mail delivery software. A message that you sent could not be delivered to one or more of its recipients. This is a temporary error. The following address(es) deferred: mkdirenv@gmail.com Domain salmanwaheed.info has exceeded the max emails per hour (183/150 (122%)) allowed. Message will be reattempted later------- This is a copy of the message, including all the headers. ------ Received: from github-smtp2-ext1.iad.github.net ([192.30.252.192]:47441 helo=github-smtp2a-ext-cp1-prd.iad.github.net) by box1177.bluehost.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from <noreply@github.com>) id 1epQVz-003Jg2-Kt for hello@salmanwaheed.info; Fri, 23 Feb 2018 20:28:48 -0700 Date: Fri, 23 Feb 2018 19:23:12 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1519442881; bh=3epeHi5G5LIzZfvEt2bweUfskScaqtXkYaXDjpOMw3A=; h=From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=OqlxnB12qgJgKNAwHoxB+HKhxKxYdqoSO6Lzv6NshwYT2TGbNP8tg7NN5DZjf7eEB rKP/+ZtbRY7EzdjhsPhueCa033tNVPnH16AmSNOTp0F8W+M1tP/VcWAFg79lPg6CPh 5RISrpK7wmM9t0poVervz5/S49qr9654HOvMddFo= From: React Native Bot <notifications@github.com> Reply-To: facebook/react-native <reply@reply.github.com> To: facebook/react-native <react-native@noreply.github.com> Cc: Subscribed <subscribed@noreply.github.com> Message-ID: <facebook/react-native/issues/17696/368194967@github.com> In-Reply-To: <facebook/react-native/issues/17696@github.com> References: <facebook/react-native/issues/17696@github.com> Subject: Re: [facebook/react-native] DatePickerIOS - locale props not working (#17696) Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_5a90daa08acd0_37cd2b0b3acf6ec43363f"; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list X-GitHub-Sender: react-native-bot X-GitHub-Recipient: salmanwaheed X-GitHub-Reason: subscribed List-ID: facebook/react-native <react-native.facebook.github.com> List-Archive: https://github.com/facebook/react-native List-Post: <mailto:reply@reply.github.com> List-Unsubscribe: <mailto:unsub+00ef1b380783c4c4f0d4713c474938c5348ba7019dab742892cf0000000116a89ca092a169ce114f6811@reply.github.com>, <https://github.com/notifications/unsubscribe/AO8bOI4ZyFl7mKta-Mv3MYGIPkrzciD_ks5tX4CggaJpZM4RmdAJ> X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: hello@salmanwaheed.info X-Spam-Status: No, score=-1.0 X-Spam-Score: -9 X-Spam-Bar: - X-Ham-Report: Spam detection software, running on the system "box1177.bluehost.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see root\@localhost for details. Content preview: Thanks for posting this! It looks like you may not be using the latest version of React Native, v0.53.0, released on January 2018. Can you make sure this issue can still be reproduced in the latest version? [...] Content analysis details: (-1.0 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: github.io] -0.5 SPF_PASS SPF: sender matches SPF record 0.0 HTML_IMAGE_ONLY_32 BODY: HTML: images with 2800-3200 bytes of words 0.0 HTML_MESSAGE BODY: HTML included in message -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.4 AWL AWL: Adjusted score from AWL reputation of From: address X-Spam-Flag: NO----==_mimepart_5a90daa08acd0_37cd2b0b3acf6ec43363f Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Thanks for posting this! It looks like you may not be using the latest ve= rsion of React Native, v0.53.0, released on January 2018. Can you make su= re this issue can still be reproduced in the latest version? = I am going to close this, but please feel free to open a new issue if you= are able to confirm that this is still a problem in v0.53.0 or newer. <sub>[How to Contribute](https://facebook.github.io/react-native/docs/con= tributing.html#bugs) =E2=80=A2 [What to Expect from Maintainers](https://= facebook.github.io/react-native/docs/maintainers.html#handling-issues)</s= ub>-- = You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: #17696 (comment) 967=----==_mimepart_5a90daa08acd0_37cd2b0b3acf6ec43363f Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable <p>Thanks for posting this! It looks like you may not be using the latest= version of React Native, v0.53.0, released on January 2018. Can you make= sure this issue can still be reproduced in the latest version?</p> <p>I am going to close this, but please feel free to open a new issue if = you are able to confirm that this is still a problem in v0.53.0 or newer.= </p> <p><sub><a href=3D"https://facebook.github.io/react-native/docs/contribut= ing.html#bugs" rel=3D"nofollow">How to Contribute</a> =E2=80=A2 <a href=3D= "https://facebook.github.io/react-native/docs/maintainers.html#handling-i= ssues" rel=3D"nofollow">What to Expect from Maintainers</a></sub></p> <p style=3D"font-size:small;-webkit-text-size-adjust:none;color:#666;">&m= dash;<br />You are receiving this because you are subscribed to this thre= ad.<br />Reply to this email directly, <a href=3D"https://github.com/face= book/react-native/issues/17696#issuecomment-368194967">view it on GitHub<= /a>, or <a href=3D"https://github.com/notifications/unsubscribe-auth/AO8b= OPzWas2lZ6mCZqfB-LRBT5LiDn3bks5tX4CggaJpZM4RmdAJ">mute the thread</a>.<im= g alt=3D"" height=3D"1" src=3D"https://github.com/notifications/beacon/AO= 8bOHYWOjFgif8EYA8Wcq5GaELSc6-_ks5tX4CggaJpZM4RmdAJ.gif" width=3D"1" /></p=<div itemscope itemtype=3D"http://schema.org/EmailMessage"> <div itemprop=3D"action" itemscope itemtype=3D"http://schema.org/ViewActi= on"> <link itemprop=3D"url" href=3D"https://github.com/facebook/react-native= /issues/17696#issuecomment-368194967"></link> <meta itemprop=3D"name" content=3D"View Issue"></meta> </div> <meta itemprop=3D"description" content=3D"View this Issue on GitHub"></me= ta> </div> <script type=3D"application/json" data-scope=3D"inboxmarkup">{"api_versio= n":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name"= :"GitHub"},"entity":{"external_key":"github/facebook/react-native","title= ":"facebook/react-native","subtitle":"GitHub repository","main_image_url"= :"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d8= 8-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubuse= rcontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.= png","action":{"name":"Open in GitHub","url":"https://github.com/facebook= /react-native"}},"updates":{"snippets":[{"icon":"PERSON","message":"@reac= t-native-bot in #17696: Thanks for posting this! It looks like you may no= t be using the latest version of React Native, v0.53.0, released on Janua= ry 2018. Can you make sure this issue can still be reproduced in the late= st version? \n\nI am going to close this, but please feel free to open a = new issue if you are able to confirm that this is still a problem in v0.5= 3.0 or newer.\n\n\u003csub\u003e[How to Contribute](https://facebook.gith= ub.io/react-native/docs/contributing.html#bugs) =E2=80=A2 [What to Expect= from Maintainers](https://facebook.github.io/react-native/docs/maintaine= rs.html#handling-issues)\u003c/sub\u003e\n\n"}],"action":{"name":"View Is= sue","url":"#17696 (comment) mment-368194967"}}}</script>=…----==_mimepart_5a90daa08acd0_37cd2b0b3acf6ec43363f--
- locked and limited conversation to collaborators
on May 15, 2018
![https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open](https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open){kind=link}
Is this a bug report?
Yes
Have you read the Contributing Guidelines?
Yes
Environment
Environment:
OS: macOS Sierra 10.12.6
Node: 8.9.0
Yarn: 0.27.5
npm: 5.5.1
Watchman: 4.7.0
Xcode: Xcode 9.1 Build version 9855
Android Studio: Not Found
Packages: (wanted => installed)
react: 16.1.1=> 16.1.1
react-native: 0.50.3 => 0.50.3
Steps to Reproduce
Expected Behavior
Date picker should show buddhist calendar type.
Actual Behavior
It showing default (gregorian) calendar type.