Skip to content

Decimal-pad keyboardType not showing comma separator on Samsung keyboards #21733

Description

@FRizzonelli

Is this a bug report?
YES

Environment

React Native Environment Info:
System:
OS: macOS High Sierra 10.13.5
CPU: x64 Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz
Memory: 113.07 MB / 16.00 GB
Shell: 3.2.57 - /bin/bash
Binaries:
Node: 10.11.0 - /usr/local/bin/node
Yarn: 1.10.1 - /usr/local/bin/yarn
npm: 4.2.0 - ~/.npm-packages/bin/npm
Watchman: 4.7.0 - /usr/local/bin/watchman
SDKs:
iOS SDK:
Platforms: iOS 11.4, macOS 10.13, tvOS 11.4, watchOS 4.3
Android SDK:
Build Tools: 22.0.1, 23.0.1, 23.0.2, 23.0.3, 24.0.1, 24.0.2, 24.0.3, 25.0.0, 25.0.1, 25.0.2, 25.0.3, 26.0.0, 26.0.1, 26.0.2, 27.0.0, 27.0.1, 27.0.2, 27.0.3, 28.0.2
API Levels: 16, 17, 18, 22, 23, 24, 25, 26, 27
IDEs:
Android Studio: 3.0 AI-171.4443003
Xcode: 9.4.1/9F2000 - /usr/bin/xcodebuild
npmPackages:
@types/react: ^16.4.7 => 16.4.14
@types/react-native: ^0.56.4 => 0.56.19
react: 16.4.1 => 16.4.1
react-native: 0.56.0 => 0.56.0
npmGlobalPackages:
create-react-native-app: 1.0.0
react-native-cli: 2.0.1
react-native-rename: 2.1.9

Description

I'm trying to use the decimal-pad on my textinput, the feature was released in 0.56.0. The decimal dot is correctly showed in the keyboard and it's working (even on Samsung devices). The problem is that I'm not able to use the comma in the keyboard, which in almost every Europe culture is the default separator.

I've already check the PR here and also found all the related bug: #12988 #17474
I'm currently testing on a Samsung J5 with Android 6.0.1 and on a Samsung S9 with 8.0.0

Is there any workaround where I can explicitly set the digits for Android?

EDIT:
After some other testing, I can confirm that the bug is related to Samsung keyboards. On HTC and Nexus works great, even with custom keyboards.

Reproducible Demo

<TextInput keyboardType="decimal-pad" />

Activity

  1. react-native-bot commented on Oct 11, 2018

    @react-native-bot
    Collaborator

    Can you run react-native info and edit your issue to include these results under the Environment section?

    If you believe this information is irrelevant to the reported issue, you may write [skip envinfo] under Environment to let us know.

  2. react-native-bot commented on Oct 11, 2018

    @react-native-bot
    Collaborator

    It looks like you are using an older version of React Native. Please update to the latest release, v0.57 and verify if the issue still exists.

    The ":rewind:Old Version" label will be removed automatically once you edit your original post with the results of running react-native info on a project using the latest release.

  3. changed the title [-]Decimal-pad keyboard not showing comma separator[/-] [+]Decimal-pad keyboard not showing comma separator on Samsung keyboards[/+] on Oct 12, 2018
  4. changed the title [-]Decimal-pad keyboard not showing comma separator on Samsung keyboards[/-] [+]Decimal-pad keyboardType not showing comma separator on Samsung keyboards[/+] on Oct 12, 2018
  5. react-native-bot commented on Oct 30, 2018

    @react-native-bot
    Collaborator

    I am closing this issue because it does not appear to have been verified on the latest release, and there has been no followup in a while.

    If you found this thread after encountering the same issue in the latest release, please feel free to create a new issue with up-to-date information by clicking here.

  6. locked as resolved and limited conversation to collaborators on Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Ran CommandsOne of our bots successfully processed a command.Resolution: LockedThis issue was locked by the bot.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions