Rename internal fields#17798
Closed
sebmarkbage wants to merge 1 commit into
Closed
Conversation
One day we'll use private fields for this but until then I'm just going to rename these every version until people get the hint.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e381e58:
|
trueadm
approved these changes
Jan 7, 2020
Collaborator
Like.. manually?.. |
gaearon
reviewed
Jan 7, 2020
gaearon
approved these changes
Jan 7, 2020
gaearon
left a comment
gaearon
left a comment
Collaborator
There was a problem hiding this comment.
OK but maybe fix the RN inspector overlay somehow?
facebook-github-bot
added
the
React Core Team
gaearon
requested changes
Jan 8, 2020
gaearon
left a comment
gaearon
left a comment
Collaborator
There was a problem hiding this comment.
Let's have a strategy for the cases we found first.
gaearon
approved these changes
Mar 24, 2020
gaearon
left a comment
gaearon
left a comment
Collaborator
There was a problem hiding this comment.
Let's get this into the next sync? And fix up the known cases (E2E). We'll need to give heads-up to Enzyme.
Collaborator
|
We did this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One day we'll use private fields for this but until then I'm just going to rename these every version until people get the hint.
This is actually better than if we change fields while keeping the same name. Because at least this will fail early (and often bailout) where as once found, people tend to assume that the data structure is there and as such throws random errors to users.