Skip to content

Translate FAQ > File Structure page to pt-BR#37

Merged
fjoshuajr merged 3 commits into
reactjs:masterfrom
RodolfoSilva:translate-faq-structure
Feb 10, 2019
Merged

Translate FAQ > File Structure page to pt-BR#37
fjoshuajr merged 3 commits into
reactjs:masterfrom
RodolfoSilva:translate-faq-structure

Conversation

@RodolfoSilva

Copy link
Copy Markdown
Contributor

#1

@fjoshuajr fjoshuajr added the needs review A pull request ready to be reviewed label Feb 9, 2019

@cezaraugusto cezaraugusto left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @RodolfoSilva! translation is 100% and no feedback on that.

I guess you updated the links as some translations did previously but we decided to not going this way and keep link sources as-is. I'm sorry for the confusion, could you please change them? I'll approve after that

// not wanted anymore
Existe uma maneira recomendada para estruturar os projetos em React? {#existe-uma-maneira-recomendada-para-estruturar-os-projetos-em-react}
// wanted
Existe uma maneira recomendada para estruturar os projetos em React? {##is-there-a-recommended-way-to-structure-react-projects}

@cezaraugusto cezaraugusto added needs author response Changes requested needing author's input and removed needs review A pull request ready to be reviewed labels Feb 9, 2019
@RodolfoSilva

Copy link
Copy Markdown
Contributor Author

Yes, sure @cezaraugusto 👍 . I'm going to do it now.

@RodolfoSilva

Copy link
Copy Markdown
Contributor Author

Done @cezaraugusto

cezaraugusto
cezaraugusto previously approved these changes Feb 9, 2019

@cezaraugusto cezaraugusto left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @RodolfoSilva LGTM

@cezaraugusto cezaraugusto added needs +1 Needs another approval before merging and removed needs author response Changes requested needing author's input labels Feb 9, 2019

@fjoshuajr fjoshuajr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the comments, please.

Comment thread content/docs/faq-structure.md Outdated
Comment thread content/docs/faq-structure.md Outdated
Comment thread content/docs/faq-structure.md Outdated
@fjoshuajr fjoshuajr added needs author response Changes requested needing author's input and removed needs +1 Needs another approval before merging labels Feb 9, 2019
@RodolfoSilva

Copy link
Copy Markdown
Contributor Author

@fjoshuajr done!, Thanks 😄

@fjoshuajr fjoshuajr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks,

LGTM 🎉

@fjoshuajr

Copy link
Copy Markdown
Contributor

thanks @RodolfoSilva LGTM

Ok, will merge this.

@fjoshuajr
fjoshuajr merged commit 41b66dd into reactjs:master Feb 10, 2019
@fjoshuajr fjoshuajr added 🌐 translated Translation is completed for this page and removed needs author response Changes requested needing author's input labels Feb 10, 2019
devin-ai-integration Bot pushed a commit to WalissonRodrigo/pt-br.react.dev that referenced this pull request Jul 9, 2026
* Translate `FAQ > File Structure` page to pt-BR

* Revert links

* Update faq-structure.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🌐 translated Translation is completed for this page

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants