Skip to content

Publish to CocoaPods #38

Closed
Closed

Description

@jspizziri

Thanks for all your work on this project.

Could you please publish the packages to CocoaPods? podspec's currently don't support specifying a dependency that isn't published on CocoaPods.org, so currently you can't install these packages as a dependency of another package.

Thanks!

Activity

  1. mickael-menu commented on Mar 1, 2022

    @mickael-menu
    Member

    I will raise the subject on our weekly dev call and get back to you. The libs are already taken on CocoaPods.org so we can't update them at the moment.

    Are you able to use SPM or Carthage alternatively, or you really need CocoaPods?

  2. jspizziri commented on Mar 1, 2022

    @jspizziri
    ContributorAuthor

    Thanks for the response!

    I'm actually hoping to build an open source react-native wrapper for this project, and to my knowledge that only supports Cocoapods out of the box.

    You might be able to go through the process to claim the existing pods:

    https://guides.cocoapods.org/making/getting-setup-with-trunk.html

  3. jspizziri commented on Mar 9, 2022

    @jspizziri
    ContributorAuthor

    @mickael-menu any update here?

  4. mickael-menu commented on Mar 9, 2022

    @mickael-menu
    Member

    @jspizziri Yes, if possible we'd like to avoid the extra load of maintaining the podspecs on the CocoaPods repository.

    According to @aferditamuriqi, React Native works with Carthage and also custom Pods. However I couldn't find any information about Carthage support and saw this issue.

    @aferditamuriqi Would you mind chiming in and explain how you would address this? Thank you.

  5. jspizziri commented on Mar 9, 2022

    @jspizziri
    ContributorAuthor

    @mickael-menu , I've never seen anyone use Carthage in React Native, and I work with it extensively on a number of projects. @aferditamuriqi can you please provide documentation on this?

    Regarding the overhead of maintaining the podspecs, I'm not sure I'm following. There are already podspecs in the repository, the only thing that needs to be done is to identify an official CocoaPod package name. Then all you need is a GitHub action to automatically publish whenever you release a new version. The only work would be to set it up initially. Or are you saying you want to completely drop support for Cocoapods altogether (i.e. remove the podspecs from the repo)?

    I may be out of the loop, and I know Carthage's popularity is growing, but AFAIK CocoaPods still has the most adoption. If it's not supported then it means people who can't use it (like the RN community currently) won't be able to use the awesome work you all have done here.

    Would you be open to automating the publishing process via GitHub hooks? You could probably the bumping of the podspec file updates too if that's the concern.

  6. aferditamuriqi commented on Mar 11, 2022

    @aferditamuriqi
    Member

    Hi @jspizziri I will try to answer all of your questions.

    • yes we are not actively supporting CocoaPods on the Readium swift projects. We had decided this over a year ago to drop support for CocoaPods. We do support Carthage and SPM.

    • The PodSpecs we have in the repo are still there as contributors have taken the time to keep those up to date, but when no contributions on updates on the PodSpecs are made, we will be removing them.

    • React Native and Dependency Management:
      You can have more than one dependency manager in the same project. in a few of my react native projects, i left the podfile as is, which takes care of all that comes from react native, and added Carthage as well. same as in any project you will run the pod tools and you will run the Carthage commands as well. you will need to follow the Carthage instructions the same way as in any other project that uses only Carthage.
      Also you could even combine all 3 CocoaPods, Carthage and SPM in one project. there is nothing hacky or different about adding different dependency managers.

    If you really prefer to use CocoaPods and do not want to use our recommended Carthage or SPM, then make sure you link the CocoaPods with the links to the PodSpecs in the Github, and link those first before any other pods.

    Bottom line, I personally do not recommend using the Readium dependencies in a React Native project via CocoaPods.

    Oh and one more thing, when they say React Native doesn't support Carthage, they mean that the React Native dependencies have no Carthage support. Not that you can't add other dependencies to the project in other means.

  7. jspizziri commented on Mar 11, 2022

    @jspizziri
    ContributorAuthor

    @aferditamuriqi ,

    Thanks for the additional information. I'm aware you can combine different package managers, but I don't really see that as a good solution. React Native doesn't support Carthage meaning users would have to use CocoaPods and Carthage like you said, which IMHO is a poor user experience at the very least. The bottom line is that until Carthage or SPM overtake CocoaPods in the RN world, it's not great.

    If you're allowing the community to continue to maintain the spec files then what would be the drawback of simply having an official release on CocoaPods.org? As I said before, the release could be entirely automated, so I'm not sure how it creates overhead for the core Readium team.

    As you mention, you'll deprecate them when there are no community members maintaining them. But this conversation is effectively about me wanting to help maintain them for the purposes of leveraging this package more easily in the React Native world. However, there's a fundamental problem, the specs as they are don't work because not being properly published to CocoaPods.

    If I'm willing to help automate the publishing/release to CocoaPods and have a vested interest in keeping the specs up to date would that not qualify in your mind for community maintenance?

    Thanks again for all your help! I just don't want to maintain a fork of the project exclusively for the purpose of publishing it to CocoaPods.

  8. aferditamuriqi commented on Mar 11, 2022

    @aferditamuriqi
    Member

    @jspizziri

    I understand your point of view on this. But over the last 5 years we are working on, evolving and implementing the Readium toolkit, we didn't see the demand of fully supporting CocoaPods and as mentioned before a decision has been made on that. Aside from the Readium toolkit itself there are a number of dependencies that are as well not published through CocoaPods, and that's not something we are planning to do. Not to mention the LCP repos which are no where to be published publicly. The minimum on support we have is the PodSpecs in this repo. And this is the part where contributions are accepted.

    On another note, which organization are you representing and is this organization a member of the Readium Foundation? You can sure join our calls as a member and contributor to get a better understanding of goals etc. I am sorry this is not what you were expecting.

  9. jspizziri commented on Mar 11, 2022

    @jspizziri
    ContributorAuthor

    @aferditamuriqi , thats unfortunate but thanks for communicating it. If the react-native wrapper I'm writing gains traction hopefully that decision can be revisited in the future.

    I work here, here's our GitHub. We're not a member of the Readium Foundation and I only found out about the project a week ago or so, but it's by far the most complete implementation that I've come across and I appreciate all the architectural rigor behind it.

    I'm not entirely sure what being a member of the Foundation would offer, the hierarchy of Readium vs ERDLab, etc isn't super clear to me.

  10. aferditamuriqi commented on Mar 11, 2022

    @aferditamuriqi
    Member

    @jspizziri We sure can revisit in the future. and i am really sorry i couldn't provide a better outcome for you. But please keep us posted and we can make adjustments eventually if your wrapper gains traction.

    I see, that makes sense, as i hadn't seen you yet in other channels. Great though you found out about the Readium project and feel free to ask any questions. As of the member ship, i will forward you to @llemeurfr so he can better address your question.

  11. jspizziri commented on Mar 23, 2022

    @jspizziri
    ContributorAuthor
  12. smoores-dev commented on May 30, 2023

    @smoores-dev
    Contributor

    Hi all! Just wanted to chime in here and say: I'm starting a new project and hoping to use react-native-readium! I'm using Expo (I don't have an Apple machine, so I have to use some sort of cloud build service), which I believe would Just Work™ (at least, with development builds) if the Readium Swift libraries could be found by CocoaPods. As it is, I'm struggling to figure out the correct incantations to modify the Podfile to point directly at the GitHub repos.

    Anyway, all that to say, if you would be open to reconsidering CocoaPods support, I would appreciate it greatly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions