Repository navigation
[TypeDeclaration] Speed up AddReturnTypeDeclarationRector with cheap method-name gate before type resolution - #8655
Merged
Merged
Conversation
…method-name gate before type resolution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rule subscribes to every
Class_node and loops over all configuredAddReturnTypeDeclarationentries, callingisObjectType()on each.isObjectType()resolves the node type viagetType(), which is not cached, so for a config with K entries the same class type is resolved K times per class - even for entries whose target method the class does not even declare (symfony/doctrine/phpunit sets configure dozens of entries).This adds a cheap method-name gate: build the set of method names on the class once (plain AST, lowercased to match the case-insensitive
isName), and skip an entry before the expensiveisObjectType()when the class has no method of that name. The existing innerisNameloop is kept unchanged as the authority, so the gate can only false-positive (then the inner loop rejects as before), never false-negative - behavior is identical.Tests, ECS and PHPStan pass locally.