Repository navigation
[perf] Speed up Transform and EarlyReturn rules with cheap guards before type checks and walks - #8670
Merged
Conversation
…ore type checks and walks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Performance refactor of 4 rules. No behavior change - all fixtures pass unchanged.
WrapReturnRector-isObjectType()now runs after the method-name match, so the object type is only resolved when a method name matches the configured wrap.ArrayDimFetchToMethodCallRector- the configured method lookup and itsnullcheck now run beforeisObjectType(), so a config entry with no method for the current magic handler skips the type check.PreparedValueToEarlyReturnRector- the cheapareNodesEqual($assign->var, $returnedExpr)check now runs before thefindFirst()subtree walk.ReturnEarlyIfVariableRector- the assign-target structural checks (Variable, not static/global, not by-ref, matches the returned variable) now run before the docblock is parsed.Reordering is safe: all moved checks are side-effect-free bail conditions that must all pass to proceed.