Skip to content

fix(e2e): add promoter ControllerConfiguration in scheme to avoid warning failed to get existing controller configuration promoter-controller-configuration - #1463

Open
chengfang wants to merge 1 commit into
redhat-developer:masterfrom
chengfang:e2e.warning
Open

chengfang wants to merge 1 commit into
redhat-developer:masterfrom
chengfang:e2e.warning

Conversation

@chengfang

Copy link
Copy Markdown
Contributor

What does this PR do?
improve e2e setup to avoid repeated warnings:
"failed to get existing controller configuration promoter-controller-configuration"

PR acceptance criteria:

  • Documentation was updated and verified using make serve-docs
  • Unit tests were updated
  • E2E tests were updated

What type of PR is this?

/kind cleanup

Special notes to the reviewer:

…ning failed to get existing controller configuration promoter-controller-configuration

Signed-off-by: Cheng Fang <cfang@redhat.com>

Assisted-by: Claude <noreply@anthropic.com>
@openshift-ci openshift-ci Bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process. label Oct 23, 2026
@coderabbitai

coderabbitai Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
📥 Commits

Reviewing files that changed from the base of the PR and between b61fc0a and 461a461.

📒 Files selected for processing: 1
  • test/e2e/suite_test.go
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.

📝 Summary

Summary by CodeRabbit

  • Tests
    • Expanded end-to-end test setup to recognize additional GitOps and Kubernetes API types, improving coverage for scenarios that use these APIs.

The E2E suite now imports and registers the GitOps Promoter and Kubernetes API registration APIs in its scheme during setup. Registration errors use the existing setup expectation.

Changes: E2E API scheme setup

Layer / File(s) Summary
API scheme registration
test/e2e/suite_test.go
The suite imports the GitOps Promoter and Kubernetes API registration APIs and registers their types with the Kubernetes scheme during setup. Registration errors use the existing expectation.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Suggested reviewers: olivergondza

Merge Risk: ⚪ Minimal · up to 461a4

No actionable merge-blocking risk remains.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title names the change: adding the promoter ControllerConfiguration to the scheme to stop the controller-configuration warning. The diff registers the GitOps Promoter API and Kubernetes API regist…
Description check Passed The description states the purpose: improve e2e setup to avoid the repeated warning 'failed to get existing controller configuration promoter-controller-configuration'. It relates to the scheme regist…
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the change: adding the promoter ControllerConfiguration to the scheme to stop the controller-configuration warning. The diff registers the GitOps Promoter API and Kubernetes API registration API in the e2e suite scheme, which matches. The title is long (155 characters) but specific and accurate.

Full details: Description check

Explanation

The description states the purpose: improve e2e setup to avoid the repeated warning 'failed to get existing controller configuration promoter-controller-configuration'. It relates to the scheme registration change. It also lists the acceptance criteria checkboxes, which are unchecked. The description is brief but on-topic.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from anandrkskd and jannfis October 23, 2026 13:23
@openshift-ci

openshift-ci Bot commented Oct 23, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jgwest for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chengfang

Copy link
Copy Markdown
Contributor Author

the gosec ci failures are caused by new version of gosec. To be resolved by PR #1461

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/cleanup Categorizes issue or PR as related to cleaning up code, process.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant