fix(xreadgroup): dont parse number props - #3133
Merged
Merged
Conversation
bobymicroby
approved these changes
Nov 10, 2025
nkaradzhov
force-pushed
the
xreadgroup-claim-numbers
branch
2 times, most recently
from
November 19, 2025 11:37
9b1d32d to
300646b
Compare
![jit-ci[bot]](https://avatars.githubusercontent.com/in/142441?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ The following Jit checks failed to run:
- secret-detection-trufflehog
- static-code-analysis-semgrep-pro
#jit_bypass_commit in this PR to bypass, Jit Admin privileges required.
More info in the Jit platform.
Initially, there was a bug in the server where the two additional props were returned as string instead of number. This should now be fixed in the GA, so no need to parse to Number anymore.
nkaradzhov
force-pushed
the
xreadgroup-claim-numbers
branch
from
November 19, 2025 11:54
300646b to
722d4c0
Compare
nkaradzhov
marked this pull request as ready for review
November 19, 2025 12:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Waiting for GA release to be ready