Skip to content

fix(test-utils): support object format for defaultDockerVersion with separate tag and version - #3169

Merged
nkaradzhov merged 1 commit into
redis:masterfrom
nkaradzhov:testimageparser
Jan 27, 2026
Merged

nkaradzhov merged 1 commit into
redis:masterfrom
nkaradzhov:testimageparser

Conversation

@nkaradzhov

Copy link
Copy Markdown
Collaborator

Description

  • Update defaultDockerVersion to use { tag, version } format to handle custom Docker tags that don't contain semantic versions
  • Tag 'custom-21183968220-debian-amd64' now correctly parses as version 8.6
  • Updated all test-utils files across packages to use the new format

Checklist

  • Does npm test pass with this change (including linting)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

@bobymicroby bobymicroby left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…guments

- Rename dockerImageVersionArgument to dockerImageTagArgument for Docker tag
- Add optional dockerImageVersionArgument for explicit Redis version
- Update workflow to use matrix object format with tag and version properties
- Keep defaultDockerVersion with { tag, version } object format for local development
- Version resolution priority: CLI --redis-version > default version > parse from tag
- Bump test container version custom-21183968220-debian-amd64
@nkaradzhov
nkaradzhov merged commit fc47608 into redis:master Jan 27, 2026
15 checks passed
@nkaradzhov
nkaradzhov deleted the testimageparser branch January 27, 2026 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants