Repository navigation
fix(querybuilder): preserve table metadata through generic transforms - #37
Merged
Merged
Conversation
Read existing metadata instead of re-inferring the recursive table shape. Cover context-bound callbacks in native pipes; implicit selector inference remains a separate issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve table metadata through callback-based native pipes. Three files; local gates pass. Merge before preparing the next patch release.
Why
Problem: applying an option after generic transforms can erase a table's field and constraint types.
Fixes
Metadata retention:
Regression coverage:
Mechanical changes:
Risks & Testing Needed
Scope: this fixes metadata extraction, not every inference problem.
→ Unannotated option-selector shorthand mixed with ordinary transforms remains tracked as
effect-qb-ciq.Requirement: fields and constraint facts must remain accurate after composition.
→ The new assertions fail against the merged PR #36 baseline and pass with this change.
Not tested:
Build status: local types, 741 tests / 80 snapshots, build, and packed Node consumer smoke tests pass.
Test Plan
bun run test:types bun test --coverage bun run build bun run test:packCI must also pass the existing Node 22/24/26 package and database-integration jobs before merge.
Rollback
Restores the preceding typing implementation and removes these regression assertions. No data migration is involved.