Repository navigation
Fix CI: make font-scan regression wait native-only - #1
Merged
richard1912 merged 3 commits intoOct 13, 2026
Conversation
The desktop and web apps call setup_context_for_language directly, not setup_context, so fonts::start_scan never ran: the font catalog stayed empty, the Format Cells font list showed only the standard names and cells formatted with an installed font couldn't render in it. Start the scan there too (once; later calls and wasm are no-ops). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ut3hr3a13szpQdQ7gbYbfc
richard1912
force-pushed
the
fix/font-scan-at-startup
branch
from
October 13, 2026 12:34
8364cb3 to
4379043
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The regression test added in storytold#974 makes CI fail because it calls
Instant::now, which the repository forbids on paths that may reach wasm.Replace its clock-based wait with a bounded native-only poll. Keep the font-scan assertion; wasm takes the synchronous no-scan path without sleeping or reading a clock. The original font-scan implementation stays intact.
Validation in Ubuntu 24.04 / Rust 1.99.0:
8364cb379a24b5e42d034b2af3bdbbc686d29e2a:cargo clippy -p gridcraft-ui-egui --test font_scan_starts -- -D warningsreproduces the disallowedInstant::nowfailure.497304e66335f186769d2de607485c3be2811a57:cargo xtask cipasses all eight gates (fmt, Clippy, native tests, assets, dependency layers, wasm, parity and keytips). The font-scan regression assertion remains and passes.git diff --checkpasses.The separate Windows font-binding race described in the original PR is outside this test-only repair; no Windows GUI behavior is claimed verified here.
This follow-up targets
fix/font-scan-at-startupso the repair can be incorporated into the existing upstream PR.