Repository navigation
Adopt shared documented Member rows in Inspect Web - #10903
richlander wants to merge 10 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Round 1 review model substitution: GPT-6 Astra is not advertised by the active agent harness, so the single fixed-head review seat will use the approved non-Fast GPT-6 Sol model for this cross-layer Browser adoption. Candidate remains locked at Authored by Copilot. |
|
dotnet-inspect builds robust, capable inspection features that provide foundational capabilities or compelling experiences and are conventionally sound, delightfully new or unique, or both. Round 1 is complete for PR 10903.
Progress: 1 pushed candidate, 1 usable review, 1 accepted finding. Resolution: accepted. Exact rows in the navigation pane carry only an overload index, while the click handler resolves that index against the previously selected group. Immediately after choosing exact/documented content no group is selected, so the first click is inert; a later cross-group click can target the wrong declaration. Reproduced on exact head Authored by Copilot. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
dotnet-inspect builds robust, capable inspection features that provide foundational capabilities or compelling experiences and are conventionally sound, delightfully new or unique, or both. Round 2 is complete for PR 10903.
Progress: 2 pushed candidates, 2 usable reviews, 2 accepted findings. Resolution: round 1 is resolved. The round 2 finding is accepted: Member navigation has four explicit grid rows, but failure status, filter disclosure, and declaration list become three separate children after the fixed heading/back rows. The declaration list enters an implicit auto row and a populated list collapses the filter disclosure track. Reproduced on exact head Authored by Copilot. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Round 3 accepted two blocking correctness findings at exact head
The round 1 group-aware exact-row selection repair remains resolved. The round The next candidate will preserve a completed Type document beside a failed Round 3 is complete for PR 10903.
Progress: 3 pushed candidates, 3 usable reviews, 4 accepted findings. Resolution: exact-head probes accepted both findings. Round 4 will preserve completed rows when optional documentation acquisition fails and keep selected exact-Member documentation stable across repeated Type-document group projection. Authored with GitHub Copilot CLI. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Round 4 conflict recovery merged live |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Round 4 candidate
Focused validation passed:
The complete composition file still reports two stale Package Dependency The live-base conflict probe is clean against Authored with GitHub Copilot CLI. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Documented exact MembersSystem.Text.Json 10.0.13 on the recovered PR head The Member content selector is set to documented members. The navigation Authored with GitHub Copilot CLI. |
|
Round 4 accepted one blocking correctness finding at exact head The Package Type-document cache key omits the selected runtime identifier even Exact-head reproduction evaluated the production key for the same Package,
The finding is accepted. Round 5 will add the runtime identifier to the All four prior finding occurrences are resolved:
Round 4 is complete for PR 10903.
Progress: 5 pushed candidates, 4 usable reviews, 5 accepted findings. Resolution: exact-head reproduction accepted the RID collision. Round 5 will Authored with GitHub Copilot CLI. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Round 5 candidate Both Type Member source-dependent keys now include the selected Package runtime
The latter uses the same RID-specific managed request and therefore had the Focused evidence:
Current-head Authored with GitHub Copilot CLI. |
|
Round 5 accepted one blocking correctness finding at exact head When exact Member content is retained across a same-session link restoration to An exact-head in-memory probe evaluated the authored
The result was The finding is accepted. Round 6 will preserve exact Member identity during All five prior finding occurrences are resolved:
Round 5 is complete for PR 10903.
Progress: 6 pushed candidates, 5 usable reviews, 6 accepted findings. Resolution: exact-head reproduction accepted the premature identity-validation Authored with GitHub Copilot CLI. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Round 6 candidate: This candidate repairs the accepted exact-Member restoration defect from
Focused evidence:
Authored with GitHub Copilot CLI. |
Resolve the Worker operation catalog and regenerate the combined Browser facade boundary. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Round 6 conflict recovery: Live The recovery:
Validation on the recovered head:
Round 6 remains pending. Current-head CI must pass again before the fixed-head Authored with GitHub Copilot CLI. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Round 6 recovered candidate: The first conflict-recovery head failed the fast facade digest gate because The canonical eight-facade generator now records the assembly-local Validation:
Round 6 remains pending current-head CI and fixed-head review. Authored with GitHub Copilot CLI. |
|
Round 6 accepted one blocking correctness finding at exact head When a Type's private exact-Member document is already loaded, restoring a An exact-source VM probe evaluated the authored
The loaded-private case returned The finding is accepted. If another review block is approved, Round 7 will All six prior finding occurrences are resolved:
The six-round boundary snapshot remains eligible for an operator decision: Round 6 is complete for PR 10903.
Progress: 9 pushed candidates, 6 usable reviews, 7 accepted findings. Resolution: exact-head reproduction accepted the projection-dependent identity Authored with GitHub Copilot CLI. |

dotnet-inspect builds robust, capable inspection features that provide
foundational capabilities or compelling experiences and are conventionally
sound, delightfully new or unique, or both.
Summary
Type document and documentation-composition operations
source-owned documentation capability across Package, Platform, and uploaded
Library roots
declaration-token selector enrichment without giving the Browser population
or ordering authority
declarations or substituting a success-shaped fallback
Design basis
Normative owner:
docs/design/inspect-web-subject-overview.md#owner-and-claim— Inspect Web ownsthe Browser presentation grammar while exact/documented Member content consumes
the shared Type document operations only when explicitly selected.
Supporting owners:
docs/design/type-member-inspection-documents.mdowns exact declarationidentity, population order, and documentation attachment correspondence.
docs/design/cli-verbosity-retirement.mdowns content-defined composition andthe rule that optional documentation work requires explicit demand.
Validation
--check, including Browser/Wasm productionpublish
BrowserMemberDeclarationTests: 7 passedgit diff --checkProductionFacadeContextTestsremains red for two failures already present atthe branch's starting head
6a68984f2d60027de0f79c187e3fe6e5dc22f73f:the pre-existing
TypeSignaturePresentationwire-type ownership violation andthe pre-existing unlisted
FindIndexedTypesexport. This change adds the threenew Type-document exports to that gate's expected partition; the canonical
facade generation and production publish pass.
Closes #10808