Fix reStream.sh/restream binary issues for RM2 firmware 3.27+ - #131
Draft
kalihale wants to merge 5 commits into
Draft
Fix reStream.sh/restream binary issues for RM2 firmware 3.27+#131kalihale wants to merge 5 commits into
kalihale wants to merge 5 commits into
Conversation
Fixes the 3.27 memory-offset regression and orphan restream process on exit, adds a --pen-orientation flag to correct cursor alignment on fw 3.27+ with graceful fallback for older on-device binaries, then removes pen-orientation handling entirely (both the reStream.sh glue and the restream binary's PenOrientation logic) since it proved unnecessary in practice.
Contributor
|
This appears to change the default from landscape to portrait, and remove the This also breaks compatibility with being installed via vellum by removing |
Contributor
Author
|
@Eeems Thanks for the catch! Reverted those changes and added fix for pen tracking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skip_offset) and an orphanrestreamprocess left running on the reMarkable afterreStream.shexits (can now exit with ^C)skip_offsetfrom the 3.24 version.Test plan
sh -n reStream.sh(syntax check)cargo buildforsrc/main.rsreStream.shconnects and streams from an RM2 on firmware 3.27+-c/cursor tracking is correctly aligned on 3.27+