Repository navigation
feat: drop Python 3.9 support, add rigetti-quax (1/5) (#1852) - #1858
Conversation
|
| Branch | 1852-drop-python-39 |
| Testbed | ci-runner-linux |
⚠️ WARNING: No Threshold found!Without a Threshold, no Alerts will ever be generated.
Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsflag.
Click to view all benchmark results
| Benchmark | Latency | seconds (s) |
|---|---|---|
| test/benchmarks/test_program.py::test_copy_everything_except_instructions | 📈 view plot | 10.87 s |
| test/benchmarks/test_program.py::test_instructions | 📈 view plot | 3.45 s |
| test/benchmarks/test_program.py::test_iteration | 📈 view plot | 3.50 s |
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
|
This PR has too many files to review (>50 files). |
asaites
left a comment
There was a problem hiding this comment.
This looks great. Thank you for the hard work.
I think there's a mistake in the new help Makefile target, but other than that, I only had some questions/comments on some versions used in the workflows. I don't think they need to be block the PR, though.
|
Updated rigetti-quax lower bound to 0.7.0 |
|
I don't understand the OSV check failure |
Looks like we should update |
|
Updates setuptools to >83.0 and the checkout workflow to v7 in all locations |
|
@asaites What should the version be set to before merge? |
In a certain sense, it doesn't matter, because the |
The latest pyquil release on pypi is 4.17 so I thought this would be 4.18 if we increment |
Oh interesting. |
f1884bc to
414f175
Compare
|
Squashed |
Part of the effort to land the experimental noise model and simulation module (originally PR #1848, branch
nonbreaking-noise-model) as a reviewable stack. This is PR 1 of 5; the remaining PRs stack on top of this branch and should be reviewed/merged in order. Closes #1852.This PR raises the minimum supported Python to 3.11 (dropping 3.9/3.10), adds
rigetti-quaxas a dependency (the foundation the later noise-model and simulator PRs build on), and refreshespoetry.lock, the Dockerfiles, and the GitHub Actions workflows accordingly.The bulk of the diff is mechanical typing modernization enabled by 3.11 —
Optional[X]/Union[...]→X | None,collections.abc.Callable, explicitzip(..., strict=...)— plus a couple of doctest/snapshot CI stabilizations (the QASM transpile snapshot is replaced with explicit line assertions). There is no functional behavior change in this PR.Stack
Tracked in #1863.