Repository navigation
UTB parity 3/4: pinned history and complete bundles (weighted quorum, overlap, 256 to 4) - #3
Merged
Merged
Conversation
…dles; weighted quorum, overlap and 256-to-4 tests TrustBaseHistory (create(pin), append -> APPENDED/ALREADY_HELD, entryForEpoch, epochEndRound, toBundle, fromBundle), TrustBaseBundle/Limits, TrustBaseResponseWire (public, shared with the page decoder), typed errors (Bundle, Network, BeforeGenesis, Gap, Conflict with details). Appends are serialised under a lock without I/O; epochs and rounds compare as unsigned. Shared bft-go-base history, weightedQuorum and bundles vectors.
This was referenced Nov 8, 2026
Merged
Owner
Author
|
java#3 at de67e4e: no blockers. APPROVE once CI is green.
The bundle decode refuses a non-OK status, a continuation cursor, a null end entry ID, a partial range and a mismatched end ID, matching rs#17's tightened |
Owner
Author
|
APPROVE at de67e4e, for the owner's list. CI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Owner §51, plan PR 3 (stacked on #2). Mirrors JS
TrustBaseHistory/TrustBaseBundle/TrustBaseResponseWire/TrustBaseError.tsand Rusttrust_base_history.rs.TrustBaseHistory:create(pin),append(->APPENDED/ALREADY_HELD; first entry must be the pinned genesis; successors verified against the tip; a held epoch with the same id is idempotent but its witnesses are still verified; a different id isTrustBaseConflictExceptionwith ids, unauthenticated; gap, before-genesis),entryForEpoch,epochEndRound,toBundle,fromBundle. Serialised under a lock with no I/O; snapshots are immutable lists; epochs/rounds compare unsigned (tested across 2^63).TrustBaseBundle+TrustBaseBundleLimits: tag-39015 complete bundle decode (OK status, no cursor, from genesis, consecutive, linked, end id and effective end, network) and canonical encode;TrustBaseResponseWire(public) is the shared GetTrustBase envelope that the page decoder of the next PRs reuses; the entry count is bounded from the array header.TrustBaseBundleException,TrustBaseNetworkException,TrustBaseBeforeGenesisException(chain subclasses),TrustBaseGapException,TrustBaseConflictException(+TrustBaseConflictDetails).Evidence:
./gradlew test checkstyleMain animalsnifferMainunder Temurin 11 green. Not merged by me.