Skip to content

chore(deps): upgrade oxc to 0.150.0 - #10877

Merged
shulaoda merged 4 commits into
rolldown:mainfrom
camc314:codex/oxc-main
Sep 15, 2026
Merged

shulaoda merged 4 commits into
rolldown:mainfrom
camc314:codex/oxc-main

Conversation

@camc314

@camc314 camc314 commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Upgrade Oxc Rust dependencies to 0.150.0.
  • Upgrade @oxc-project/runtime, @oxc-project/types, oxc-parser, and oxc-transform JavaScript packages to 0.150.0.
  • Regenerate the embedded Oxc runtime helper metadata for @oxc-project/runtime 0.150.0.

Root causes

oxc-project/oxc#25994

oxc-project/oxc#25994

Oxc added codegen.asciiOnly to its minifier N-API CodegenOptions. Rolldown now propagates the option from binding normalization through its raw and normalized minify options into bundled Oxc code generation, while preserving false as the default. Normalized binding options also round-trip the configured value.

The native and WASI binding declarations now expose asciiOnly, and Rolldown’s strict validator schema accepts it. Focused coverage verifies that bundled minification escapes BMP and astral Unicode only when asciiOnly is enabled. No snapshots change.

Commit: 9ef028c2ad8cfd2054818e1e758710a4ec21b3a6

@camc314
camc314 marked this pull request as ready for review September 14, 2026 15:07
Copilot AI lite review requested due to automatic review settings September 14, 2026 15:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 14, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-15T03:03:04.762005Z e5fbd44 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2dfd194494

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/rolldown/src/utils/validator.ts
@codspeed

codspeed Bot commented Sep 14, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 7 untouched benchmarks
⏩ 10 skipped benchmarks1


Comparing camc314:codex/oxc-main (1f2ea34) with main (c3c32ec)

Open in CodSpeed

Footnotes

  1. 10 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

oxc-project/oxc#25994

Oxc added codegen.asciiOnly to its minifier N-API CodegenOptions. Propagate the option from binding normalization through Rolldown’s raw and normalized minify options into Oxc code generation, while preserving false as the default. Normalized binding options now round-trip the configured value.

Regenerate the native and WASI binding declarations, which expose asciiOnly, and accept it in Rolldown’s strict validator schema. Add focused coverage proving bundled minification escapes BMP and astral Unicode only when asciiOnly is enabled. No snapshots change.

First-Bad-Oxc-Commit: 9ef028c2ad8cfd2054818e1e758710a4ec21b3a6

Oxc-Revision: 9ef028c2ad8cfd2054818e1e758710a4ec21b3a6
Regenerate the embedded Oxc runtime helpers for @oxc-project/runtime 0.150.0. Helper bodies are unchanged; only the generated version marker and virtual helper prefix advance to the published package version.
@shulaoda
shulaoda merged commit 5db55b9 into rolldown:main Sep 15, 2026
32 checks passed
@rolldown-guard rolldown-guard Bot mentioned this pull request Sep 16, 2026
shulaoda added a commit that referenced this pull request Sep 16, 2026
## [1.2.9] - 2026-09-16

### 🚀 Features

- add `MODULE_LEVEL_DIRECTIVE` warning (#10791) by @sapphi-red

### 🐛 Bug Fixes

- handle CommonJS exports through top-level `this` (#10872) by @IWANABETHATGUY
- scripts: make setup-vite CLI invocation work on Windows (#10885) by @shulaoda
- remove deleted property from output bundle proxy target (#10815) by @Vladexy88x
- treat module-scope `await using` as top-level await (#10739) by @MarshallOfSound
- watch: preserve plugin attribution in warnings (#10473) by @Nic-Polumeyv
- test-dev-server: link the workspace rolldown before building vite (#10857) by @h-a-n-a
- minify: preserve annotation comments when minified (#10854) (#10855) by @justonemorenight

### ⚡ Performance

- dev/lazy: fetch a lazy route in one request (#10789) by @h-a-n-a
- plugin: reduce binding binary size (#10776) by @Boshen
- vite-reporter: reuse emitted sourcemap sizes (#10841) by @hyfdev

### 🧪 Testing

- dev: full-bundle-mode regression test for cyclic import binding (#9946) (#9947) by @ShMcK
- cover asset option callback timings (#10870) by @IWANABETHATGUY

### ⚙️ Miscellaneous Tasks

- wait for npm bindings before publishing rolldown (#10866) by @shulaoda
- deps: update dependency @napi-rs/cli to v3.10.1 (#10889) by @renovate[bot]
- deps: update napi (#10888) by @renovate[bot]
- compress debug info archives with zstd (#10778) by @IWANABETHATGUY
- publish split debug info for release bindings (#10777) by @IWANABETHATGUY
- rolldown_utils: simplify MIME guessing and remove UTF-8 check bypass (#10884) by @shulaoda
- add npm bugs metadata for rolldown (#9694) by @kingshuaishuai
- deps: upgrade oxc to 0.150.0 (#10877) by @camc314
- deps: update rust crates (#10869) by @renovate[bot]
- deps: update dependency vite-plus to v0.3.2 (#10878) by @renovate[bot]
- deps: update rollup submodule for tests to v4.63.3 (#10880) by @rolldown-guard[bot]
- deps: update test262 submodule for tests (#10881) by @rolldown-guard[bot]
- deps: update github actions (#10867) by @renovate[bot]
- deps: update npm packages (#10868) by @renovate[bot]
- deps: update napi to v3.12.4 (#10862) by @renovate[bot]
- deps: update napi (#10861) by @renovate[bot]

### ❤️ New Contributors

* @Vladexy88x made their first contribution in [#10815](#10815)
* @MarshallOfSound made their first contribution in [#10739](#10739)
* @kingshuaishuai made their first contribution in [#9694](#9694)
* @ShMcK made their first contribution in [#9947](#9947)
* @justonemorenight made their first contribution in [#10855](#10855)

Co-authored-by: shulaoda <165626830+shulaoda@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants