You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[plugin-commonjs] incorrect default value for ignoreTryCatch option #1004
In most cases, where require calls are inside a try-catch clause, they should be left unconverted as it requires an optional dependency that may or may not be installed beside the rolled up package.
Thus, I would would expect the default value to be true since it is the value which exhibits this behavior
Actual Behavior
The default is false. The imported code gets hoisted out of the try/catch and fails at runtime as a result
Activity
jimmywarting commentedon Oct 1, 2021
maybe this can be closed now when #1005 is merged?