Skip to content

fix(windows): embed icon in executable - #10

Merged
rteoo merged 3 commits into
mainfrom
codex/port-windows-icon
Sep 26, 2026
Merged

rteoo merged 3 commits into
mainfrom
codex/port-windows-icon

Conversation

@rteoo

@rteoo rteoo commented Sep 26, 2026

Copy link
Copy Markdown
Owner

Summary

Testing

  • Verified the ICO has four entries and the two ported files match upstream PR fix(windows): embed icon in executable tobi/disktree#37 byte for byte.
  • git diff --cached --check passed.
  • Rust/Cargo and rc.exe are unavailable locally; fork CI will run lint, tests, and the Windows release icon check.

Risks

  • Windows builds require the Windows SDK resource compiler, already supplied with the MSVC SDK used by this project.

@rteoo
rteoo merged commit 471d16b into main Sep 26, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant