Skip to content

fix(linux): refuse nested mount deletion #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rteoo merged 3 commits into from
Sep 25, 2026
Merged

fix(linux): refuse nested mount deletion #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2656c6c
fix(linux): refuse nested mount deletion
rteoo Sep 25, 2026
d60b544
style(linux): match rustfmt output
rteoo Sep 25, 2026
a65e3a1
fix(linux): satisfy lint and test plan refusal
rteoo Sep 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,15 @@ jobs:
- name: Test
run: cargo xtask test

# A bind mount keeps st_dev, so this exercises the mount-ID guard rather
# than only the ordinary cross-device case.
- name: Nested bind-mount deletion regression
run: |
cargo test -p disktree-core --no-run --locked
test_bin=$(find target/debug/deps -maxdepth 1 -type f -name 'disktree_core-*' -perm -111 -print -quit)
test -n "$test_bin"
sudo unshare --mount --propagation private "$test_bin" --ignored nested_bind_mount_preserves_unmarked_files

macos:
name: macOS lint, test, and build
runs-on: macos-15
Expand Down
Loading