Fix indentation of xstring literal#1038
Merged
Merged
Conversation
Fixes indent calculation of this input ``` if false p `ls` end ```
st0012
approved these changes
Nov 26, 2024
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Nov 26, 2024
(ruby/irb#1038) Fixes indent calculation of this input ``` if false p `ls` end ``` ruby/irb@4217a46f5d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes wrong indent calculation of this input
Description
We need to distinguish
Kernel.`from`xstring_literal`.`ls`:on_backtickEXPR_BEGclass `ls`::A;end:on_backtickEXPR_CLASSp `ls`:on_backtickEXPR_CMDARGp x: `ls`:on_backtickEXPR_ARG|EXPR_LABELEDp(`ls`):on_backtickEXPR_BEG|EXPR_LABELKernel.`:on_backtickEXPR_ARGThe simplest way to check is using
state != EXPR_ARG.Known issues
As shown in the table below, checking by
state != EXPR_ARGis not perfect. But there is no easy way.p p `ls`:on_backtickEXPR_ARGKernel.`:on_backtickEXPR_ARG