Repository navigation
Conversation
Truth is, I don't know how large this is
jhawthorn
commented
Jun 8, 2025
| } | ||
| p5s = &p5s_static[0]; | ||
| for (;;) { | ||
| assert(p5s < &p5s_static[MAX_P5]); |
Member
Author
There was a problem hiding this comment.
FIXME: Ran a fuzzer against this and we definitely sometimes exceed MAX_P5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #12991 I replaced a spinlock with malloc, which is about the same performance.
I think malloc implementations have gotten better since 1990 when dtoa.c was written, but this can still be a bit of a bottleneck. We seem to mostly be allocating a few small bigints (k <= 2) at a time, so this PR adds a small on-stack buffer we can allocate from without synchronization.
I need to test this a bit more before merging.