Explicit add the timeout thread to default ThreadGroup#22
Merged
Conversation
Member
|
Yes, a test would be very useful to ensure there is no regression. |
larskanis
force-pushed
the
timeout-thread
branch
from
September 26, 2022 18:52
2e6c5b4 to
9c7c91a
Compare
Contributor
Author
|
I added a test case. |
eregon
reviewed
Sep 26, 2022
Otherwise the timeout thread would be added to the ThreadGroup of the thread that makes the first call to Timeout.timeout . Fixes bug 19020: https://bugs.ruby-lang.org/issues/19020 Add a test case to make sure the common thread doesn't leak to another ThreadGroup
larskanis
force-pushed
the
timeout-thread
branch
from
September 27, 2022 13:32
9c7c91a to
8374b2d
Compare
Member
|
@hsbt How do we make sure this change is propagated to ruby/ruby before the 3.2.0 release (and ideally before the next preview too) ? |
Member
|
Oh wow it's done automatically, awesome! ruby/ruby@9d56d99 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise the timeout thread would be added to the
ThreadGroupof the thread that makes the first call toTimeout.timeout.Fixes bug 19020: https://bugs.ruby-lang.org/issues/19020
Do you wish a test for the
ThreadGroupor is it an implementation detail?