Skip to content

Resolve old TODO#175

Merged
jamwaffles merged 2 commits into
rust-embedded-community:masterfrom
bugadani:todo
May 2, 2023
Merged

Resolve old TODO#175
jamwaffles merged 2 commits into
rust-embedded-community:masterfrom
bugadani:todo

Conversation

@bugadani

@bugadani bugadani commented May 1, 2023

Copy link
Copy Markdown
Contributor

Hi! Thank you for helping out with SSD1306 development! Please:

  • Check that you've added documentation to any new methods
  • Rebase from master if you're not already up to date
  • Add or modify an example if there are changes to the public API
  • Add a CHANGELOG.md entry in the Unreleased section under the appropriate heading (Added, Fixed, Changed, etc)
  • Run rustfmt on the project with cargo fmt --all - CI will not pass without this step
  • Check that your branch is up to date with master and that CI is passing once the PR is opened

PR description

This PR resolves an old todo item that I believe was added by myself. Relevant feature has been stable for some time now.

@bugadani
bugadani force-pushed the todo branch 4 times, most recently from 038f368 to d2252fa Compare May 1, 2023 19:58
@jamwaffles
jamwaffles merged commit 31f1201 into rust-embedded-community:master May 2, 2023
@jamwaffles

Copy link
Copy Markdown
Collaborator

Thanks!

@bugadani
bugadani deleted the todo branch May 2, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants