Skip to content

version: 0.5.0 -> 0.6.0#81

Closed
newAM wants to merge 1 commit into
masterfrom
release-0.6.0
Closed

version: 0.5.0 -> 0.6.0#81
newAM wants to merge 1 commit into
masterfrom
release-0.6.0

Conversation

@newAM

@newAM newAM commented Oct 29, 2023

Copy link
Copy Markdown
Member

No description provided.

@newAM newAM requested a review from a team as a code owner October 29, 2023 21:33
@Dirbaio

Dirbaio commented Oct 31, 2023

Copy link
Copy Markdown
Member

why not 0.5.1? there have been no breaking changes afaict?

@trueb2

trueb2 commented Oct 31, 2023

Copy link
Copy Markdown
Contributor

Conversation has been light, but hopefully we can have #78 merge before the next release. It would require a breaking change of choice of algorithm. use embedded_alloc::LlffHeap as Heap;

There hadn't really been any feature activity on this repo until I opened that PR. I would assume that the 0.6 vs 0.5.1 choice is because of the algorithm choice change.

@rmja

rmja commented Nov 2, 2023

Copy link
Copy Markdown
Contributor

I would appreciate that we could have a 0.5.1 with the allocator_api feature before we wait on the #78.

@trueb2

trueb2 commented Nov 2, 2023

Copy link
Copy Markdown
Contributor

Seems like we could do both allocator_api 0.5.1 and allocator choice 0.6. I don’t see any reason why we need to wait for either besides the natural flow of open source PR review.

@newAM newAM mentioned this pull request Nov 4, 2023
@Dirbaio Dirbaio closed this in #85 Nov 5, 2023
@newAM newAM deleted the release-0.6.0 branch November 5, 2023 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants