Repository navigation
AIX: Restore 'c_ulong' as the type of 'struct statvfs' member 'f_fsid' - #5616
Merged
Merged
Conversation
rustbot
added
O-powerpc
O-unix
S-waiting-on-review
stable-nominated
3 of 4 tasks
xingxue-ibm
force-pushed
the
aix-fix-struct-statvfs
branch
from
October 9, 2026 17:20
be9cd3a to
9f251df
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
xingxue-ibm
force-pushed
the
aix-fix-struct-statvfs
branch
from
October 9, 2026 18:54
9f251df to
da774fa
Compare
tgross35
approved these changes
Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 36da88e changed the type of
struct statvfsmemberf_fsidfromc_ulongtofsid_tfor AIX and breaks thenixbuild. In the AIX headersys/statvfs.h, the definition is as follows: for POSIX, the type off_fsidisulong_t, and for_ALL_SOURCE, it isfsid_t, which istypedef struct { unsigned int __val[2]; } fsid_t;. The binary layouts are the same. This PR restores the type off_fsidto the POSIX definitionc_ulong.@rustbot label +stable-nominated