Skip to content

Add Archive of Rust Stable Standalone Installers#733

Merged
Kobzol merged 1 commit into
rust-lang:masterfrom
yerke:yerke/old-stable-standalone-installers
May 27, 2024
Merged

Add Archive of Rust Stable Standalone Installers#733
Kobzol merged 1 commit into
rust-lang:masterfrom
yerke:yerke/old-stable-standalone-installers

Conversation

@yerke

@yerke yerke commented Mar 22, 2024

Copy link
Copy Markdown
Contributor

Closes #676

This PR adds a new page "Archive of Rust Stable Standalone Installers" that contains a list of tables of previous stable Rust version standalone installers.

Currently it works for all versions > 1.8. Versions <= 1.7 do not have v2 toml manifests. See Zulip for details.

@shepmaster @ojeda Is this what you had in mind?

Screenshots:

Screenshot 2024-03-22 at 3 33 08 AM Screenshot 2024-03-22 at 3 33 41 AM

@rustbot

rustbot commented Mar 22, 2024

Copy link
Copy Markdown
Collaborator

r? @ehuss

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 22, 2024
@yerke

yerke commented Mar 22, 2024

Copy link
Copy Markdown
Contributor Author

r? @shepmaster

Comment thread blacksmith/src/lib.rs
Comment thread src/infra/archive-stable-version-installers.md Outdated
@yerke
yerke force-pushed the yerke/old-stable-standalone-installers branch from 6f58568 to c848983 Compare April 10, 2024 05:51
@yerke

yerke commented Apr 10, 2024

Copy link
Copy Markdown
Contributor Author

r? @ehuss

@rustbot rustbot assigned ehuss and unassigned shepmaster Apr 10, 2024
@yerke

yerke commented Apr 10, 2024

Copy link
Copy Markdown
Contributor Author

@ehuss thanks a lot for taking a look. I addressed your feedback.

@yerke
yerke requested a review from ehuss April 10, 2024 05:58
@ojeda

ojeda commented Apr 10, 2024

Copy link
Copy Markdown

@shepmaster @ojeda Is this what you had in mind?

Yeah, thanks a lot!

It could be nice to have a matrix instead (but that makes it complex, i.e. empty cases would need to be handled, plus it may be not great scrolling horizontally, so it could require breaking the table in several anyway), or a selector, or at least a way to jump quickly to the right version.

But I would not worry about any of that -- even if it is just a dump of links, it is useful :)

@ehuss

ehuss commented Apr 10, 2024

Copy link
Copy Markdown
Contributor

I am not on the infra or release teams, so I'm not sure I am the appropriate person to be approving things on their behalf. Perhaps @Mark-Simulacrum would give the green light. I'm fine with the implementation barring #733 (comment) getting resolved.

@Mark-Simulacrum Mark-Simulacrum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me with one implementation and one wording note.

Comment thread blacksmith/src/lib.rs Outdated
Comment thread src/infra/archive-stable-version-installers.md Outdated
@yerke
yerke force-pushed the yerke/old-stable-standalone-installers branch from c848983 to 3dbcfd5 Compare May 5, 2024 00:23
@yerke
yerke requested a review from Mark-Simulacrum May 5, 2024 00:28
@yerke

yerke commented May 5, 2024

Copy link
Copy Markdown
Contributor Author

@Mark-Simulacrum Do you mind taking another look when you get a chance? Thanks.

@Kobzol

Kobzol commented May 27, 2024

Copy link
Copy Markdown
Member

Could you remove the merge commits please?

@yerke
yerke force-pushed the yerke/old-stable-standalone-installers branch from ab13eed to 771066c Compare May 27, 2024 06:29
@yerke

yerke commented May 27, 2024

Copy link
Copy Markdown
Contributor Author

@Kobzol done!

@Kobzol Kobzol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous comments have been resolved, so I think that we can merge this.

@Kobzol
Kobzol merged commit 5b5f635 into rust-lang:master May 27, 2024
@yerke
yerke deleted the yerke/old-stable-standalone-installers branch October 14, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show the standalone installers for earlier releases (FIXME)

7 participants