Skip to content

Don't mark reachable extern fns as internal - #10539

Merged
bors merged 1 commit into
rust-lang:masterfrom
alexcrichton:external-linkage
Nov 18, 2013
Merged

Don't mark reachable extern fns as internal#10539
bors merged 1 commit into
rust-lang:masterfrom
alexcrichton:external-linkage

Conversation

@alexcrichton

@alexcrichton alexcrichton commented Nov 18, 2013

Copy link
Copy Markdown
Member

If a function is marked as external, then it's likely desired for use with some
native library, so we're not really accomplishing a whole lot by internalizing
all of these symbols.

@alexcrichton

alexcrichton commented Nov 18, 2013

Copy link
Copy Markdown
Member Author

This is the implementation that I wanted to see of #9945

@thestinger

thestinger commented Nov 18, 2013

Copy link
Copy Markdown
Contributor

I again don't see why this should be tied to ABI. Why not just make fully public (reachable) paths in a binary external like clang does? An LTO pass can internalize everything but main without hitting the problems we do.

The rationale for adding the building_library check was due to reachable not working very well. Assuming it works well, the only difference between a executable and a library should be that #[inline] doesn't make functions get considered reachable in an executable.

huonw
huonw reviewed Nov 18, 2013
View reviewed changes
Comment thread src/test/run-pass/extern-fn-reachable.rs

@huonw huonw Nov 18, 2013

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could call these external1, ..., internal1, ..., rather than relying on this assertion chain to describe the intended behaviour.

@huonw huonw Nov 18, 2013

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Relying on just this assertion chain.)

@thestinger

thestinger commented Nov 18, 2013

Copy link
Copy Markdown
Contributor

(also, statics)

bors added a commit that referenced this pull request Nov 18, 2013
@bors
auto merge of #10539 : alexcrichton/rust/external-linkage, r=pcwalton
e0db813 
If a function is marked as external, then it's likely desired for use with some
native library, so we're not really accomplishing a whole lot by internalizing
all of these symbols.
@alexcrichton
Don't mark reachable extern fns as internal
4ddeef3 
If a function is marked as external, then it's likely desired for use with some
native library, so we're not really accomplishing a whole lot by internalizing
all of these symbols.
bors added a commit that referenced this pull request Nov 18, 2013
@bors
auto merge of #10539 : alexcrichton/rust/external-linkage, r=pcwalton
6c8b702 
If a function is marked as external, then it's likely desired for use with some
native library, so we're not really accomplishing a whole lot by internalizing
all of these symbols.
@bors bors closed this Nov 18, 2013
@bors
bors merged commit 4ddeef3 into rust-lang:master Nov 18, 2013
@alexcrichton
alexcrichton deleted the external-linkage branch November 19, 2013 07:06
flip1995 pushed a commit to flip1995/rust that referenced this pull request Mar 24, 2023
@bors
Auto merge of rust-lang#10539 - flip1995:rustup, r=flip1995
d5e2a7a 
Rustup

r? `@ghost`
changelog: none
@jieyouxu jieyouxu mentioned this pull request Jan 13, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 13, 2025
@bors
Auto merge of rust-lang#135458 - jieyouxu:migrate-extern-fn-reachable…
392a405 
…, r=<try>

tests: Port `extern-fn-reachable` to rmake.rs

Part of rust-lang#121876.

## Summary

This PR ports `tests/run-make/extern-fn-reachable` to use `rmake.rs`. Notable changes:

- We now use the `object` crate and look at the exported symbols specifically.
- This test's coverage regressed against windows-msvc back in [replace dynamic library module with libloading rust-lang#90716](rust-lang#90716), but since we use `object` now, we're able to claw the test coverage back.
- The checks are now stricter:
    1. It no longer looks for substring symbol matches in `nm` textual outputs, it inspects the symbol names precisely.
    2. We now also explicitly check for the presence of leading underscore in exported symbol names on apple vs non-apple targets.

## History

- Test was initially introduced as a run-pass[^run-pass] test as part of [Don't mark reachable extern fns as internal rust-lang#10539](rust-lang#10539).
- Test re-introduced as a run-make test in rust-lang#13741.
- Later, the test coverage regressed in rust-lang#90716.

[^run-pass]: no longer a thing nowadays

Supersedes rust-lang#128314.
Co-authored with `@lolbinarycat.`

r? `@ghost`

try-job: x86_64-msvc
try-job: i686-msvc
try-job: i686-mingw
try-job: x86_64-mingw-1
try-job: x86_64-apple-1
try-job: aarch64-apple
try-job: test-various
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 14, 2025
@bors
Auto merge of rust-lang#135458 - jieyouxu:migrate-extern-fn-reachable…
c0a7d85 
…, r=<try>

tests: Port `extern-fn-reachable` to rmake.rs

Part of rust-lang#121876.

## Summary

This PR ports `tests/run-make/extern-fn-reachable` to use `rmake.rs`. Notable changes:

- We now use the `object` crate and look at the exported symbols specifically.
- This test's coverage regressed against windows-msvc back in [replace dynamic library module with libloading rust-lang#90716](rust-lang#90716), but since we use `object` now, we're able to claw the test coverage back.
- The checks are now stricter:
    1. It no longer looks for substring symbol matches in `nm` textual outputs, it inspects the symbol names precisely.
    2. We now also explicitly check for the presence of leading underscore in exported symbol names on apple vs non-apple targets.
- Added another case of `#[no_mangle] fn fun6() {}` (note the lack of `pub`) to check that Rust nameres visibility is orthogonal to symbol visiblity in dylib.

## History

- Test was initially introduced as a run-pass[^run-pass] test as part of [Don't mark reachable extern fns as internal rust-lang#10539](rust-lang#10539).
- Test re-introduced as a run-make test in rust-lang#13741.
- Later, the test coverage regressed in rust-lang#90716.

[^run-pass]: no longer a thing nowadays

Supersedes rust-lang#128314.
Co-authored with `@lolbinarycat.`

r? `@ghost`

try-job: x86_64-msvc
try-job: i686-msvc
try-job: i686-mingw
try-job: x86_64-mingw-1
try-job: x86_64-apple-1
try-job: aarch64-apple
try-job: test-various
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 16, 2025
@bors
Auto merge of rust-lang#135458 - jieyouxu:migrate-extern-fn-reachable…
5cd16b7 
…, r=lqd

tests: Port `extern-fn-reachable` to rmake.rs

Part of rust-lang#121876.

## Summary

This PR ports `tests/run-make/extern-fn-reachable` to use `rmake.rs`. Notable changes:

- We now use the `object` crate and look at the exported symbols specifically.
- This test's coverage regressed against windows-msvc back in [replace dynamic library module with libloading rust-lang#90716](rust-lang#90716), but since we use `object` now, we're able to claw the test coverage back.
- The checks are now stricter:
    1. It no longer looks for substring symbol matches in `nm` textual outputs, it inspects the symbol names precisely.
    2. We now also explicitly check for the presence of leading underscore in exported symbol names on apple vs non-apple targets.
- Added another case of `#[no_mangle] fn fun6() {}` (note the lack of `pub`) to check that Rust nameres visibility is orthogonal to symbol visibility in dylib.

## History

- Test was initially introduced as a run-pass[^run-pass] test as part of [Don't mark reachable extern fns as internal rust-lang#10539](rust-lang#10539).
- Test re-introduced as a run-make test in rust-lang#13741.
- Later, the test coverage regressed in rust-lang#90716.

[^run-pass]: no longer a thing nowadays

Supersedes rust-lang#128314.
Co-authored with `@lolbinarycat.`

try-job: x86_64-msvc
try-job: i686-msvc
try-job: i686-mingw
try-job: x86_64-mingw-1
try-job: x86_64-apple-1
try-job: aarch64-apple
try-job: test-various
U007D pushed a commit to U007D/rust-mos that referenced this pull request Aug 21, 2026
@bors @rylev @yoshuawuyts
Merge rust-lang#10539
e52d47a 
10539: Add "generate delegate methods" assist r=Veykril a=yoshuawuyts

_Co-authored with `@rylev_.`

This patch adds a new assist: "generate delegate method" which creates a method that calls to a method defined on an inner field. Delegation is common when authoring newtypes, and having IDE support for this is the best way we can make this easier to author in Rust, bar adding language-level support for it. Thanks!

Closes rust-lang#5944.

## Example

__before__
```rust
struct Age(u8);
impl Age {
    fn age(&self) -> u8 {
        self.0
    }
}

struct Person {
    ag$0e: Age,
}
```

__after__
```rust
struct Age(u8);
impl Age {
    fn age(&self) -> u8 {
        self.0
    }
}

struct Person {
    age: Age,
}

impl Person {
    $0fn age(&self) -> u8 {
        self.age.age()
    }
}
```

Co-authored-by: Ryan Levick <me@ryanlevick.com>
Co-authored-by: Yoshua Wuyts <yoshuawuyts@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alexcrichton @thestinger @huonw @bors